MOB-350 break down transactions to msg and send #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnqh
requested review from
rosepuppy,
aforaleka,
jaredvu,
moo-onthelawn,
ruixhuang and
mike-dydx
jaredvu
reviewed
Mar 18, 2024
| @@ -433,25 +469,45 @@ export class Post { | |||
| goodTilBlockTime?: number, | |||
| broadcastMode?: BroadcastMode, | |||
| ) : Promise<BroadcastTxAsyncResponse | BroadcastTxSyncResponse | IndexedTx> { | |||
| const msgs: Promise<EncodeObject[]> = new Promise((resolve) => { | |||
| const msg = await this.cancelOrderMsg( | |||
There was a problem hiding this comment.
Can we inline this.cancelOrderMsg into the Promise.resolve(...)?
There was a problem hiding this comment.
@jaredvu What's the best coding pattern to do that? msg is a single object, and send take a promise for multiple msgs.
jaredvu
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only breaks down existing transaction functions to two parts, one to construct the Msg and one to send the Msg.
This will enable us to send multiple Msgs in one transaction in future PR.