TRCL-3691 v4-client: Add signing function for push #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanDYDX
reviewed
Sep 13, 2024
prashanDYDX
reviewed
Sep 13, 2024
rosepuppy
reviewed
Sep 13, 2024
| @@ -147,6 +147,12 @@ export async function connectWallet(mnemonic: string): Promise<string> { | |||
| globalThis.wallet = await LocalWallet.fromMnemonic(mnemonic, BECH32_PREFIX); | |||
| globalThis.nobleWallet = await LocalWallet.fromMnemonic(mnemonic, NOBLE_BECH32_PREFIX); | |||
|
|
|||
| const { privateKey, publicKey } = deriveHDKeyFromMnemonic(mnemonic); | |||
There was a problem hiding this comment.
we are already setting the hdKey in deriveMnemomicFromEthereumSignature, are we able to use it?
This way we shouldn't need to make deriveHDKeyFromMnemonic
There was a problem hiding this comment.
deriveMnemomicFromEthereumSignature is called during onboarding only, and client stores the mnemonic. This is why the current compliance flow doesn't work since deriveMnemomicFromEthereumSignature is not called every time.
prashanDYDX
previously approved these changes
Sep 13, 2024
rosepuppy
reviewed
Sep 13, 2024
| * | ||
| * @returns Priv/pub keys | ||
| */ | ||
| export const deriveHDKeyFromMnemonic = ( |
There was a problem hiding this comment.
nit: maybe we can call this from exportMnemonicAndPrivateKey
rosepuppy
approved these changes
Sep 13, 2024
yogurtandjam
pushed a commit
that referenced
this pull request
Sep 16, 2024
* Add native function to sign push notification token registration payload * Bump version * Fix * Clean up * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add native function to sign push notification token registration payload. Also add function to derive keys from mnemonic. This also fixes the function signCompliancePayload().