Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip submit method for cctp withdrawals [OTE-640] #241

Closed
wants to merge 2 commits into from

Conversation

yogurtandjam
Copy link
Contributor

@yogurtandjam yogurtandjam commented Sep 17, 2024

adds submitToSkipAPI method on nobleclient.
converts cctpMultiMsgWithdraw to use submitToSkipAPI instead of custom send method.

Tested by performing a successful withdrawal to avalanche USDC and confirming that we used skip's submit endpoint.

This will ensure that all CCTP withdrawals are either auto-sweepable back into a user's dydx wallet or tracked by skip without relying on their auto-tracking polling logic.

Technically this method doesn't need to/shouldn't live here but it feels like overkill to create a skipClient when we don't have a timeline for cutting over other paths to use the skip API.

@yogurtandjam yogurtandjam changed the title feat: skip submit method for cctp withdrawals [OTE-620] feat: skip submit method for cctp withdrawals [OTE-640] Sep 17, 2024
Copy link

linear bot commented Sep 17, 2024

@dydxprotocol dydxprotocol deleted a comment from linear bot Sep 17, 2024
@yogurtandjam
Copy link
Contributor Author

synced with @rosepuppy - we're going to try to implement this directly in v4-web to pilot it before adding this to v4-clients-js.

if/when we do add to v4-client-js, we'll go ahead and immediately implement the SkipClient rather than leave it in a 'need to be refactored' state

@yogurtandjam
Copy link
Contributor Author

going to try to pilot this in web first. if we like it we can move to clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant