Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package node modules #248

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: package node modules #248

merged 1 commit into from
Sep 19, 2024

Conversation

yogurtandjam
Copy link
Contributor

@yogurtandjam yogurtandjam commented Sep 18, 2024

semantic-release is smart enough to know to not pack any node modules, so we have to purposefully override via .npmignore

However, i accidentally created.... version 3.16. We'll need @BrendanChou to remove it https://www.npmjs.com/package/@dydxprotocol/v4-client-js?activeTab=versions (sorry 🙇 )

@yogurtandjam yogurtandjam force-pushed the test-release branch 2 times, most recently from a7ee916 to fac9005 Compare September 19, 2024 02:22
@yogurtandjam yogurtandjam changed the title testing releases fix: package node modules Sep 19, 2024
@yogurtandjam yogurtandjam marked this pull request as ready for review September 19, 2024 02:32
@yogurtandjam yogurtandjam enabled auto-merge (squash) September 19, 2024 02:42
@yogurtandjam yogurtandjam force-pushed the test-release branch 3 times, most recently from 8514342 to 70774bc Compare September 19, 2024 13:27
@yogurtandjam yogurtandjam merged commit 10cef7a into main Sep 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants