[TS] [CLOB-895] v0.38.2: Cancel order examples
#44
Conversation
| @@ -37,7 +37,7 @@ async function test(): Promise<void> { | |||
| side, | |||
| price, | |||
| 0.01, | |||
| randomInt(100_000_000), | |||
| randomInt(MAX_CLIENT_ID), | |||
There was a problem hiding this comment.
Suggestion: can we abstract this into a function? Maybe call it getRandomClientId?
There was a problem hiding this comment.
Gonna ignore this for now.
| console.log(error.message); | ||
| } | ||
|
|
||
| await sleep(5000); // wait for placeOrder to complete |
There was a problem hiding this comment.
Why is this sleep necessary for Short-Term orders?
| console.log(error.message); | ||
| } | ||
|
|
||
| await sleep(5000); // wait for placeOrder to complete |
There was a problem hiding this comment.
Can you note that for stateful orders, it can only be canceled after it's added to a block (which i'm assuming is why there's a sleep here)
Maybe also add a log statement "waiting for long-term order placement to included in a block"?
| subaccount, | ||
| shortTermOrderClientId, | ||
| OrderFlags.SHORT_TERM, | ||
| 'ETH-USD', |
There was a problem hiding this comment.
Metapoint not addressable in this PR: I think the V4 client should expose the concept of an order ID to programmatic traders
It's confusing that if any of these params change the order ID is diff and that's all under the hood
lucas-dydx
force-pushed
the
jonfung/ts_cancel_long_term
branch
from
8d85635 to
a8e785c
Compare
lucas-dydx
changed the title
v0.38.2: Cancel order examples
No description provided.