Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get request for delayed complete bridge messages #45

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

aforaleka
Copy link
Contributor

No description provided.

Copy link
Contributor

@rosepuppy rosepuppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM

@@ -36,7 +36,7 @@
"@cosmjs/stargate": "^0.30.1",
"@cosmjs/tendermint-rpc": "^0.30.1",
"@cosmjs/utils": "^0.31.1",
"@dydxprotocol/v4-proto": "^0.2.1",
"@dydxprotocol/v4-proto": "^0.3.0-dev.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern here is if we bump v4-proto again, the bridge feature would be lost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm yea will resync and see we can actually publish a non dev version, otherwise doing it to unblock dev work for now

@aforaleka aforaleka merged commit ef3c5d6 into main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants