TRCL-2812 optimization #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnqh
requested review from
rosepuppy,
mikemag-dev,
aforaleka,
jaredvu and
ruixhuang
# Conflicts: # v4-client-js/__native__/__ios__/v4-native-client.js # v4-client-js/__native__/__ios__/v4-native-client.js.map # v4-client-js/package.json
|
Needs more testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some significant optimization.
So for SHORT_TERM orders, there should be no more round trips before sending the transaction. Otherwise, it will still query onchain for account info, or retrieving market info/query block/query account in parallel.
I am sure my TS syntax is not the best. I would like to see some detailed review, and/or integrated testing with iOS/web.