Feature/trcl 2812 optimization #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # v4-client-js/__native__/__ios__/v4-native-client.js # v4-client-js/__native__/__ios__/v4-native-client.js.map # v4-client-js/package.json
johnqh
requested review from
rosepuppy,
mikemag-dev,
aforaleka,
jaredvu and
ruixhuang
rosepuppy
reviewed
Oct 9, 2023
| @@ -159,11 +182,11 @@ export class Post { | |||
| private async signTransaction( | |||
| wallet: LocalWallet, | |||
| messages: EncodeObject[], | |||
| account: Account, | |||
There was a problem hiding this comment.
I wonder if we can make the account param optional.
and we can fallback to:
const account = await this.account(wallet.address, undefined);
That way we won't break existing integrations either.
rosepuppy
reviewed
Oct 9, 2023
| @@ -76,12 +79,22 @@ export class Post { | |||
| async simulate( | |||
| wallet: LocalWallet, | |||
| messaging: () => Promise<EncodeObject[]>, | |||
| account: () => Promise<Account>, | |||
rosepuppy
approved these changes
Oct 10, 2023
Comment on lines
+116
to
+117
| const msgsPromise = await messaging(); | ||
| const accountPromise = account ? (await account()) : this.account(wallet.address!); |
There was a problem hiding this comment.
Suggested change
| const msgsPromise = await messaging(); | |
| const accountPromise = account ? (await account()) : this.account(wallet.address!); | |
| const msgsPromise = messaging(); | |
| const accountPromise = account ? account() : this.account(wallet.address!); |
Since we are using promise.all later, we do not need to await here, since the await will unravel the promise.
Comment on lines
+86
to
+87
| const msgsPromise = messaging(); | ||
| const accountPromise = account ? (await account()) : this.account(wallet.address!); |
There was a problem hiding this comment.
Suggested change
| const msgsPromise = messaging(); | |
| const accountPromise = account ? (await account()) : this.account(wallet.address!); | |
| const msgsPromise = messaging(); | |
| const accountPromise = account ? account() : this.account(wallet.address!); |
Since we are using promise.all later, we do not need to await here, since the await will unravel the promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized by
Tested by plugging in the v4-native-client.js into iOS app, and monitored network traffic with Charles.