update fee denom, url, use dydx testnet network config in posting txns #65
Conversation
| @@ -81,7 +81,7 @@ def fetch_dydx_testnet(cls) -> "NetworkConfig": | |||
| chain_id="dydx", | |||
| url="grpc+https://v4.testnet.dydx.exchange", | |||
| fee_minimum_gas_price=5000000000, | |||
There was a problem hiding this comment.
I just noticed that we have this config as well. Can you update https://github.com/dydxprotocol/v4-clients/blob/main/v4-client-py/v4_client_py/chain/aerial/client/utils.py#L21 so that the fee param is Optional and if it's None, to use this value instead?
|
Also need to update version |
where's version? |
|
updated value to 25000000000 per @johnqh slack convo |
dydxwill
changed the title
| amount=5_000_000, | ||
| amount=5, |
There was a problem hiding this comment.
Any reason for this change?
There was a problem hiding this comment.
no reverted change here
| @@ -81,7 +81,7 @@ def fetch_dydx_testnet(cls) -> "NetworkConfig": | |||
| chain_id="dydx", | |||
| url="grpc+https://v4.testnet.dydx.exchange", | |||
| fee_minimum_gas_price=5000000000, | |||
There was a problem hiding this comment.
Can we use the same number was TS?
25000000000
| fee_denomination="dv4tnt", | ||
| chain_id="dydx-testnet-4", | ||
| url="grpc+https://dydx-testnet-archive.allthatnode.com:9090", | ||
| fee_minimum_gas_price=4630550000000000, |
There was a problem hiding this comment.
You are mixing gas price and gas, and then essentially pass in a fixed gas for every function.
The gas is a calculated number based on the complexity of the function. So a fixed number can work for one function but not another.
Another issue: it is not clear whether it is using uusdc or adv4tnt for gas. They have different exponents and the real difference is factor of 10^12. If MM uses this code on mainnet, they may end up a huge shock!
The proper gas string format should be "$gas$denom".
Given we are close to mainnet, and MM are using the Python client, this is too dangerous.
No description provided.