feat: upgrade skip client to 0.15.5 #1368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tinaszheng
commented
Dec 13, 2024
| useEffect(() => { | ||
| if (!testFlags.showNewDepositFlow) return; |
There was a problem hiding this comment.
these queries don't need to be prefetched unless youre using the new deposit flow
tinaszheng
commented
Dec 13, 2024
| // so any useQuery that uses the skipClient can use that id as a query key | ||
| // to ensure it has the most up-to-date skipClient | ||
| const { skipClient, skipClientId } = useMemo( | ||
| const { skipClient, skipInstanceId } = useMemo( |
There was a problem hiding this comment.
renaming to be more accurate
tinaszheng
force-pushed
the
tina/skip-upgrade
branch
from
303788a to
5083ca4
Compare
tinaszheng
commented
Dec 13, 2024
| @@ -87,14 +87,14 @@ export const useTransfers = () => { | |||
| const debouncedAmountBN = useMemo(() => MustBigNumber(debouncedAmount), [debouncedAmount]); | |||
|
|
|||
| const chainsQuery = useQuery({ | |||
| queryKey: ['transferEligibleChains', skipClientId], | |||
| queryKey: ['transferEligibleChains'], | |||
There was a problem hiding this comment.
new instance of the skip client shouldnt trigger a re-query here since these are agnostic to whatever chain or logged in state the user is in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this upgrades our version of SkipClient to 0.15.5 and also updates our usage of it