Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CCTP withdraw #188

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Implement CCTP withdraw #188

merged 3 commits into from
Dec 12, 2023

Conversation

rosepuppy
Copy link
Contributor

Screen.Recording.2023-12-07.at.5.36.43.PM.mov

depends on dydxprotocol/v4-abacus#174 and dydxprotocol/v4-clients#90


Views

  • src/views/forms/AccountManagementForms/WithdrawForm.tsx
    • Pass isCctp for onsubmit and notification

Constants/Types

  • src/constants/notifications.ts
    • Add TransferNotificationTypes to be more explicit with the transfer type
    • Update hard coded 'withdrawal' and 'deposit' types accordingly

Functions

  • src/lib/abacus/dydxChainTransactions.ts

    • Implement TransactionType.WithdrawToNobleIBC
    • Implement TransactionType.CctpWithdraw
  • src/lib/abacus/index.ts

    • Add method for commitCCTPWithdraw

Hooks

  • src/hooks/useSubaccount.tsx
    • Update sendSquidWithdraw to go through abacus for cctp withdraws

Packages

  • update v4-abacus and v4-client-js

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 6:01pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 6:01pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants