Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install is failing #107

Closed
foxfriends opened this issue Feb 8, 2024 · 9 comments · Fixed by #116
Closed

cargo install is failing #107

foxfriends opened this issue Feb 8, 2024 · 9 comments · Fixed by #116

Comments

@foxfriends
Copy link

I have a version already installed from before, so I know it's working... but when I try to cargo install mdbook-graphviz --force it no longer works, using all the latest (Rust 1.76).

Works when I build from the repo directly though, might just be a dependency version thing and needs a republish

@foxfriends
Copy link
Author

Ah I see it's because the toolchain is 1.72 which is used when I build from the repo, and something does not work on 1.76 which is used when I use cargo install (even cargo install --path .)

@tautschnig
Copy link

Note that PRs #104 and #106 are also failing - those try to update some dependencies, but I think what needs to happen is that all of these dependencies are upgraded together (plus some source changes are required).

@lavajuno
Copy link

lavajuno commented Feb 12, 2024

It looks like mdbook 0.4.37 bumped pulldown-cmark to 10.0.0, but mdbook-graphviz depends on pulldown-cmark-to-cmark 11.2 (which does not yet support pulldown-cmark 10.0.0). I am able to build it with mdbook 0.4.36 and pulldown-cmark 0.9.6, but as @tautschnig mentioned source changes in pulldown-cmark-to-cmark and here are needed.

AtomicFS added a commit to 9elements/firmware-action that referenced this issue Feb 15, 2024
- There is an issue with mdbook v0.4.37 and mdbook-graphviz
- [issue 107](dylanowen/mdbook-graphviz#107)
AtomicFS added a commit to 9elements/firmware-action that referenced this issue Feb 15, 2024
- There is an issue with mdbook v0.4.37 and mdbook-graphviz
- [issue 107](dylanowen/mdbook-graphviz#107)
AtomicFS added a commit to 9elements/firmware-action that referenced this issue Feb 15, 2024
- There is an issue with mdbook v0.4.37 and mdbook-graphviz
- [issue 107](dylanowen/mdbook-graphviz#107)
AtomicFS added a commit to 9elements/firmware-action that referenced this issue Feb 15, 2024
- There is an issue with mdbook v0.4.37 and mdbook-graphviz
- dylanowen/mdbook-graphviz#107
@Alextopher
Copy link

Does installing with the --locked flag fix the problem?

You may also have to stay back on mdbook version 0.4.26 until this crate's dependencies can be updated.

cargo install --locked mdbook-graphviz

@GlenDC
Copy link

GlenDC commented Feb 29, 2024

0.4.26 was yanked from <crates.io>. I use 0.4.27 instead and together with the locked flag this works like a charm.

@foxfriends
Copy link
Author

Even 0.4.36 worked for me, it's only the latest 0.4.37 that has issues

@Cypher1
Copy link
Collaborator

Cypher1 commented Apr 9, 2024

Should be fixed in #116

Just need a new release to go out.

@tautschnig
Copy link

Confirming that this works fine now (model-checking/kani#3136 demonstrates it). Thank you!

@dylanowen dylanowen linked a pull request Apr 10, 2024 that will close this issue
@GlenDC
Copy link

GlenDC commented Apr 10, 2024

Can confirm as well, updated to latest together with mdbook in plabayo/rama@ff5c4e5, and it builds fine both in CI and on my dev machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants