Update pulldown-cmark to 0.11 #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the view of a preprocessor this isn't a SemVer compatible change and probably needs a minor version bump: https://github.com/dylanowen/mdbook-graphviz/actions/runs/9120113600/job/25076838288?pr=132 Also pulldown-cmark-to-cmark doesn't seem to support 0.11 yet |
|
😦 Indeed. Thanks for letting me know. I did not realize the pulldown_cmark types were exposed, and we updated in 0.4.37 to 0.10 and nobody mentioned anything at the time. I'll revert it for now. We'll probably need to do some kind of public re-export. |
ehuss
added a commit
to ehuss/mdBook
that referenced
this pull request
May 17, 2024
…cmark" This reverts commit 8884008, (rust-lang#2381) reversing changes made to 3d6caa5. The `pulldown_cmark` types are a public API, which I did not realize.
This was referenced May 17, 2024
|
Thanks for the quick fix! I think we ran into issues with 0.4.37 as well but I neglected to warn anyone here 😬: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.11.0
Note that math is not yet supported. However, due to the new Event variant, I decided to include math script in the search index. I don't know if that is the right thing to do, but seems like something we can figure out later if we start using the math feature.