Merge pull request #9 from dylibso/required-vs-nullable

Support nullable vs required
dylibso · Nov 11, 2024 · 60242c8 · 60242c8
2 parents 65d8cbb + 0e3a0c1
commit 60242c8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -17,7 +17,7 @@
     "typescript": "^5.3.2"
   },
   "dependencies": {
-    "@dylibso/xtp-bindgen": "1.0.0-rc.8",
+    "@dylibso/xtp-bindgen": "1.0.0-rc.11",
     "ejs": "^3.1.10"
   }
 }
diff --git a/src/index.ts b/src/index.ts
@@ -55,7 +55,7 @@ function toPythonType(property: Property): string {
   }
 
   if (!tp) throw new Error("Cant convert property to Python type: " + property.type)
-  if (!property.nullable) return tp
+  if (!property.nullable && !property.required) return tp
   return `Optional[${tp}]`
 }