Add cppcheck and fix errors (#114)

Add workflow with cppcheck analysis and fix current issues indicated by the tool.

.github/actions/run-cppcheck/action.yaml

@@ -0,0 +1,26 @@
+# Copyright 2024 Dynatrace LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Run static code analysis with cppcheck"
+description: "Runs cppcheck on whole source code, excluding third-party"
+
+runs:
+  using: "composite"
+  steps:
+    - name: "Install cppcheck"
+      shell: bash
+      run: sudo apt-get install -y cppcheck
+    - name: "Run cppcheck"
+      shell: bash
+      run: cppcheck -i $GITHUB_WORKSPACE/third_party $GITHUB_WORKSPACE --inline-suppr --error-exitcode=1

.github/workflows/build-and-test-debug.yaml

@@ -48,3 +48,4 @@ jobs:
 
       - name: "Run component tests"
         uses: ./.github/actions/run-component-tests
+

.github/workflows/cppcheck.yaml

@@ -0,0 +1,31 @@
+# Copyright 2023 Dynatrace LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: "Checkout and run static analysis"
+
+on:
+  [push, pull_request]
+
+jobs:
+  run-static-analysis:
+    runs-on: ${{ matrix.runner }}
+    strategy:
+      matrix:
+        runner: [ubuntu-latest]
+    steps:
+      - name: "Checkout source code of the repository"
+        uses: actions/checkout@v4
+      - name: "Run static code analysis with cppcheck"
+        uses: ./.github/actions/run-cppcheck
+

liblogging/src/Formatting.cpp

@@ -27,18 +27,21 @@ std::string vaFormat(const char* format, va_list args) noexcept {
 	int len{std::vsnprintf(result.data(), result.size() + 1, format, args)};
 
 	if (len <= 0) {
+		va_end(argsCopy);
 		return result;
 	}
 
 	if (len <= (int)result.size()) {
 		result.resize(len);
+		va_end(argsCopy);
 		return result;
 	}
 
 	result.resize(len);
 	len = std::vsnprintf(result.data(), result.size() + 1, format, argsCopy);
 
 	if (len <= 0) {
+		va_end(argsCopy);
 		return {};
 	}
 

libservice/test/AggregatorTest.cpp

@@ -33,6 +33,7 @@ void PrintTo(const Service& service, std::ostream* os) {
 
 class IpAddressCheckerMock : public IpAddressChecker {
 public:
+	// cppcheck-suppress syntaxError ; sporadic false error occurred on following line
 	MOCK_METHOD(bool, isV4AddressExternal, (const in_addr&), (const));
 	MOCK_METHOD(bool, isV6AddressExternal, (const in6_addr&), (const));
 };