feat(libebpfdiscoveryskel): Add sending BPF logging events to userspace #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hparzych
force-pushed
the
feat/skel/implement-sending-log-events-to-userspace
branch
from
89dd83e to
a399576
Compare
jakubrak
reviewed
Nov 3, 2023
| std::atomic<bool> stopReceived{false}; | ||
| std::thread workerThread; | ||
|
|
||
| struct perf_buffer* logPb; |
There was a problem hiding this comment.
Please move this to run() function, since it's accessed by another thread
|
|
||
| class DiscoveryBpfLogHandler { | ||
| public: | ||
| DiscoveryBpfLogHandler(DiscoveryBpf discoveryBpf, const DiscoveryConfig config); |
There was a problem hiding this comment.
Suggested change
| DiscoveryBpfLogHandler(DiscoveryBpf discoveryBpf, const DiscoveryConfig config); | |
| DiscoveryBpfLogHandler(DiscoveryBpf& discoveryBpf, const DiscoveryConfig& config); |
| void wait(); | ||
|
|
||
| DiscoveryConfig config; | ||
| DiscoveryBpf discoveryBpf; |
There was a problem hiding this comment.
Suggested change
| DiscoveryBpf discoveryBpf; | |
| DiscoveryBpf& discoveryBpf; |
| running = true; | ||
|
|
||
| logPb = perf_buffer__new( | ||
| bpf_map__fd(discoveryBpf.skel->maps.logEventsPerfMap), |
There was a problem hiding this comment.
discoveryBpf is not synchronized across threads. Is it safe?
There was a problem hiding this comment.
After discussion we're going to refactor this so that we pass the map itself to BpfLogHandler instead of skel.
| LOG_TRACE("Discovery BPF log event handler loop is starting."); | ||
| int err{0}; | ||
| while (!stopReceived) { | ||
| err = perf_buffer__poll(logPb, config.logPerfPollInterval.count()); |
There was a problem hiding this comment.
config is not synchronized
| @@ -28,3 +28,13 @@ __attribute__((always_inline)) inline static bool dataProbeIsBeginningOfHttpRequ | |||
| return len >= DISCOVERY_MIN_HTTP_REQUEST_LENGTH && | |||
| (dataProbeEqualToString(ptr, "GET /", 5) == 5 || dataProbeEqualToString(ptr, "POST /", 6) == 6); | |||
| } | |||
|
|
|||
| __attribute__((always_inline)) inline static int dataCopyString(const char* src, char* dest, size_t len) { | |||
There was a problem hiding this comment.
wouldn't it be possible to use strcpy?
hparzych
deleted the
feat/skel/implement-sending-log-events-to-userspace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.