Add utility to determine if ip is local external #8
Conversation
…tps://github.com/dynatrace-oss/eBPF-Discovery into DMX-4386-add-utility-to-determine-if-ip-is-local-external2
…tps://github.com/dynatrace-oss/eBPF-Discovery into DMX-4386-add-utility-to-determine-if-ip-is-local-external2
pawsten
force-pushed
the
Add-utility-to-determine-if-ip-is-local-external
branch
from
251c963 to
c6beecc
Compare
pawsten
force-pushed
the
Add-utility-to-determine-if-ip-is-local-external
branch
from
c6beecc to
6a1b063
Compare
pawsten
force-pushed
the
Add-utility-to-determine-if-ip-is-local-external
branch
from
9c8b70b to
898c2aa
Compare
| protected: | ||
| void moveBridges(); | ||
| public: | ||
| IpAddressChecker(const NetlinkCalls &calls); |
There was a problem hiding this comment.
GMock cookbook recommends using interfaces instead of concrete class: http://google.github.io/googletest/gmock_cook_book.html#alternative-to-mocking-concrete-classes
I'm curious, what is your opinion?
There was a problem hiding this comment.
This is small project and most work is one-time. I don't see value in additional boilerplate.
| void addIpIfce(IpIfce&& ifce); | ||
| void markBridge(int idx); | ||
| protected: | ||
| void moveBridges(); |
There was a problem hiding this comment.
could we somehow make this private?
There was a problem hiding this comment.
It's protected because it's called in UT what is required.
| #include <unistd.h> | ||
|
|
||
| static constexpr uint32_t BUFFLEN{4096}; | ||
| static constexpr uint32_t IP_CLASS_C{0x0000a8c0}; // 192.168.*.* |
There was a problem hiding this comment.
I see that both uint32_t and IPv4 are used across the files. I think that deciding upon only one of these for IPv4 addresses and masks would make the code cleaner
|
I've added small remarks but it's ready be merged. |
* Added Utility to termine whether ipv4 is external local * Added gsl to conanfile * Added recognizing ipv4 link local addresses * File NetlinkCalls added Co-authored-by: Hubert Parzych <hubert.parzych@dynatrace.com>
No description provided.