Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved app.js logging #64

Closed

Conversation

tiitha
Copy link
Contributor

@tiitha tiitha commented Oct 16, 2023

No description provided.

@tiitha tiitha requested a review from a team as a code owner October 16, 2023 19:59
@W3D3
Copy link
Contributor

W3D3 commented Oct 24, 2023

Hi @tiitha & thx for the contribution.

Note that your commit messages need to follow this structure:

:gitmoji: type(scope?): subject
body?
footer?

Sorry for not having this in the contributor guideline yet, but you could just squash & use this as your commit message:
🔊 feat(user-auth-service) Improve logging

// load environment variable from .env; needed for ./utils/database
require('dotenv').config()
} else {
app.use(logger('[:date[iso]] :status :userid :req[header] ":method :url HTTP/:http-version" - :response-time ms'));
app.use(logger('[:date[iso]] :remote-addr :userid :req[header] ":method :url HTTP/:http-version" - :body ":user-agent" ":referrer" :status :response-time ms'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NIT] Inconsistent indentation

@tiitha tiitha closed this Oct 24, 2023
@tiitha tiitha deleted the feature/improve-user-auth-service-logs branch October 24, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants