if isConsented, don't re-prompt for optional permissions

e-mission · Oct 9, 2024 · 03dd1f0 · 03dd1f0
1 parent 655f843
commit 03dd1f0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/www/js/onboarding/onboardingHelper.ts b/www/js/onboarding/onboardingHelper.ts
@@ -73,7 +73,7 @@ export function getPendingOnboardingState(): Promise<OnboardingState> {
   );
 }
 
-async function readConsented() {
+export async function readConsented() {
   return readConsentState().then(isConsented) as Promise<boolean>;
 }
 

diff --git a/www/js/usePermissionStatus.ts b/www/js/usePermissionStatus.ts
@@ -5,9 +5,7 @@ import { useTranslation } from 'react-i18next';
 import { useAppTheme } from './appTheme';
 import { logDebug, logWarn } from './plugin/logger';
 import { AlertManager } from './components/AlertBar';
-import { storageGet } from './plugin/storage';
-
-const HAS_REQUESTED_NOTIFS_KEY = 'HasRequestedNotificationPermission';
+import { readConsented } from './onboarding/onboardingHelper';
 
 let DEVICE_PLATFORM: 'android' | 'ios';
 let DEVICE_VERSION: number;
@@ -368,12 +366,12 @@ const usePermissionStatus = () => {
   //load when ready
   useEffect(() => {
     if (appConfig && window['device']?.platform) {
-      storageGet(HAS_REQUESTED_NOTIFS_KEY).then((hasRequestedNotifs) => {
+      readConsented().then((isConsented) => {
         DEVICE_PLATFORM = window['device'].platform.toLowerCase();
         DEVICE_VERSION = window['device'].version.split('.')[0];
         setupPermissionText();
         logDebug('setting up permissions');
-        createChecklist(hasRequestedNotifs);
+        createChecklist(isConsented);
       });
     }
   }, [appConfig]);
-Original file line number
+Diff line change
@@ Expand Up @@
       );
     }
-    async function readConsented() {
+    export async function readConsented() {
       return readConsentState().then(isConsented) as Promise<boolean>;
     }
@@ Expand Down @@