Skip to content

Commit

Permalink
add a comment about the notifications
Browse files Browse the repository at this point in the history
we had a bug related to this call, so adding a note to future development to make sure we're aware of the ramifications that this can cause.
  • Loading branch information
Abby Wheelis committed Oct 18, 2023
1 parent 416a111 commit 0584278
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions www/js/splash/startprefs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ let _req_consent;
let _curr_consented;

function writeConsentToNative() {
//note that this calls to the notification API,
//so should not be called until we have notification permissions
//see https://github.com/e-mission/e-mission-docs/issues/1006
return window['cordiva'].plugins.BEMDataCollection.markConsented(_req_consent);
};

Expand Down

0 comments on commit 0584278

Please sign in to comment.