Skip to content

Commit

Permalink
💚 ⬆️ Upgrade the pinned version of the runner to 14-large (#1153)
Browse files Browse the repository at this point in the history
* 💚 ⬆️  Upgrade the pinned version of the runner to 14-large

This should still have the correct environment variable because `14-large` runs x64
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

`macos-14` now runs amd, and we have to figure out how to run it.
Maybe we can run both as part of a schedule instead of on every pull request

* 💚 Switch to the macos version supported for free public repos

Switch to the environmental variable supported by it
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md

* 💚 Set all instances of JAVA_HOME to the new arm64 value
  • Loading branch information
shankari authored May 5, 2024
1 parent 24c8579 commit 4ec96df
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/android-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# This workflow contains a single job called "build"
build:
# The type of runner that the job will run on
runs-on: macos-13
runs-on: macos-14

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand All @@ -39,7 +39,7 @@ jobs:
echo "Default java version"
java -version
echo "Setting to Java 11 instead"
export JAVA_HOME=$JAVA_HOME_11_X64
export JAVA_HOME=$JAVA_HOME_17_arm64
java -version
echo "Checking gradle"
which gradle
Expand All @@ -53,13 +53,13 @@ jobs:
- name: Setup the cordova environment
shell: bash -l {0}
run: |
export JAVA_HOME=$JAVA_HOME_11_X64
export JAVA_HOME=$JAVA_HOME_17_arm64
bash setup/setup_android_native.sh
- name: Check tool versions
shell: bash -l {0}
run: |
export JAVA_HOME=$JAVA_HOME_11_X64
export JAVA_HOME=$JAVA_HOME_17_arm64
source setup/activate_native.sh
echo "cordova version"
npx cordova -version
Expand All @@ -77,7 +77,7 @@ jobs:
gradle -version
echo "Let's rerun the activation"
source setup/activate_native.sh
export JAVA_HOME=$JAVA_HOME_11_X64
export JAVA_HOME=$JAVA_HOME_17_arm64
echo $PATH
which gradle
gradle --version
Expand Down

0 comments on commit 4ec96df

Please sign in to comment.