README update for the changes undergone #1030
Conversation
niccolopaganini
commented
Sep 12, 2023
niccolopaganini
commented
- Updated README like @JGreenlee mentioned to successfully build
- Maintaining current version
- Will update again after updating JDK in this intel machine
1. Updated README like @JGreenlee mentioned to successfully build 2. Maintaining current version 3. Will update again after updating JDK in this intel machine
README.md
Outdated
| Make sure you switch to the "label_dashboard_profile_sept_2023" branch | ||
| ``` | ||
| git checkout label_dashboard_profile_sept_2023 | ||
| ``` | ||
|
|
||
| ``` |
There was a problem hiding this comment.
The label_dashboard_profile_sept_2023 branch is a temporary one that we are using for the current release.
It will be deleted after the release is moved to production.
| ### Activation (after install, and in every new shell) | ||
|
|
||
| ``` | ||
| $ source setup/activate_native.sh | ||
| ``` | ||
|
|
||
| ### Activation (after install, and in every new shell) | ||
|
|
There was a problem hiding this comment.
why did you remove this? I believe we do need to activate after install. How did you test this?
There was a problem hiding this comment.
I was able to build the app successfully. Let me verify the above again just to be sure.
There was a problem hiding this comment.
were you able to build the app starting in a new terminal and following the instructions in the README exactly?
When you check, please show, don't tell.
README.md
Outdated
| @@ -174,10 +171,15 @@ If connecting to a development server over http, make sure to turn on http suppo | |||
|
|
|||
| ### Run in the emulator | |||
|
|
|||
| Pick a version and execute the following: | |||
There was a problem hiding this comment.
I don't know that "type of build" == "version"
| Pick a version and execute the following: | |
| Pick a type of build and execute the following: |
You should also indicate how people can find the valid "type of build" supported.
niccolopaganini
changed the title
|
Ugh.. I lost all changes I had made to the README while pushing the changes to my repo. I will work on the README once I get some rest. Apologies (not sure what happened) |
…ated certain resources
- Added hyperlink to the title - Added output screenshot
- Updating markdown anchors
Updating markdown anchors as 4,5, & 6 weren't working
- touch up - fixed non-working markdown anchors
|
opened a new PR #1037 |
