Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility support #1112

Draft
wants to merge 4 commits into
base: service_rewrite_2023
Choose a base branch
from

Conversation

niccolopaganini
Copy link
Contributor

I repurposed the functions from one of the buttons in the Welcome Page and added on top of the scan and paste buttons. I will have to determine the size and everything.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (service_rewrite_2023@35468e5). Click here to learn what that means.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             service_rewrite_2023    #1112   +/-   ##
=======================================================
  Coverage                        ?   58.80%           
=======================================================
  Files                           ?       26           
  Lines                           ?     1420           
  Branches                        ?      320           
=======================================================
  Hits                            ?      835           
  Misses                          ?      585           
  Partials                        ?        0           
Flag Coverage Δ
unit 58.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niccolopaganini
Copy link
Contributor Author

I will update it with prettier later after addressing unpronounceable button/ button issues

…s, note-translation not found for more info button
@niccolopaganini
Copy link
Contributor Author

  • Welcome Page now supports Accessibility 🎊

@niccolopaganini niccolopaganini changed the title Accessibility changes Accessibility support Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Issues being worked on
Development

Successfully merging this pull request may close these issues.

1 participant