iOS build fix for Xcode 15 #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankari
requested changes
May 5, 2024
config.cordovabuild.xml
Outdated
| @@ -36,6 +36,8 @@ | |||
| <param name="ios-package" onload="true" value="CDVStatusBar" /> | |||
| </feature> | |||
| <platform name="ios"> | |||
| <preference name="deployment-target" value="12.0"/> | |||
There was a problem hiding this comment.
we actually want the deployment target to be 13. That is the minimum version that we have supported for a while to get our javascript to work.
|
|
||
| for (let path of paths) { | ||
| let content = fs.readFileSync(path, { encoding: 'utf-8' }); | ||
| content = content.replace(/IPHONEOS_DEPLOYMENT_TARGET = [0-9]+.0;/g, 'IPHONEOS_DEPLOYMENT_TARGET = 12.0;'); |
- We want to upgrade the pinned version of the OS to the next one - We don't want to run on `latest` because then changes to the underlying runner will break all tests, including for pull requests, and block development. Instead, we should schedule a periodic (~ once a week) check against `latest` so we know when the latest has changed, and can fix it before again bumping up the pinned version @louisg1337 Also, there was a typo in `latest` :smile
After the react rewrite, we require a min version of 13 e-mission/e-mission-docs#932 (comment) to e-mission/e-mission-docs#932 (comment) to e-mission/e-mission-docs#932 (comment) to e-mission/e-mission-docs#932 (comment)
…into ios_build_fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 26.40% 26.40%
=======================================
Files 114 114
Lines 4983 4983
Branches 1069 1064 -5
=======================================
Hits 1316 1316
Misses 3665 3665
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Great job @louisg1337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error we had while building using Xcode 15, see here.
For testing, I did a fresh install
rm -rf platforms plugin && bash setup/setup_ios_native.sh, and then tried building using Xcode andnpm run build-dev-iosand they both worked.