Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted back temporary work profile fix #1156

Merged
merged 2 commits into from
May 19, 2024

Conversation

louisg1337
Copy link
Contributor

Reverts this temporary fix that we had in place to unblock GSA users.

@shankari
Copy link
Contributor

@louisg1337 I have merged the native code changed and created a new release.
Please bump up the version number in package.cordovabuild.json so that I can merge.

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 26.59%. Comparing base (2761e19) to head (a8000c4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
+ Coverage   26.57%   26.59%   +0.01%     
==========================================
  Files         114      114              
  Lines        4993     4990       -3     
  Branches     1033     1073      +40     
==========================================
  Hits         1327     1327              
+ Misses       3666     3663       -3     
Flag Coverage Δ
unit 26.59% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
www/js/usePermissionStatus.ts 0.00% <0.00%> (ø)

Copy link
Contributor

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverting an earlier fix, code coverage is not an issue

@shankari shankari merged commit 1f5ae90 into e-mission:master May 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants