Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable custom labels #1170

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

JGreenlee
Copy link
Collaborator

This implementation has bugs (it makes a network call every time a label is input) There will be a new implementation next release; disabling this one for now

This implementation has bugs (it makes a network call every time a label is input)
There will be a new implementation next release; disabling this one for now
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.02%. Comparing base (f256364) to head (967bd82).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   30.01%   30.02%   +0.01%     
==========================================
  Files         118      118              
  Lines        5184     5182       -2     
  Branches     1162     1114      -48     
==========================================
  Hits         1556     1556              
  Misses       3624     3624              
+ Partials        4        2       -2     
Flag Coverage Δ
unit 30.02% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
www/js/App.tsx 0.00% <ø> (ø)
www/js/control/ProfileSettings.tsx 0.00% <ø> (ø)
www/js/survey/multilabel/MultiLabelButtonGroup.tsx 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@shankari shankari merged commit 428ea55 into e-mission:master Aug 28, 2024
8 checks passed
@JGreenlee JGreenlee deleted the disable-custom-labels branch August 29, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants