Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes on generic_metric and mode_specific_metrics in relation to Mo… #91
Changes on generic_metric and mode_specific_metrics in relation to Mo… #91
Changes from 5 commits
34eae86
176655a
f04e596
3182a0b
43d974b
7343606
080f4f4
7d8b2d6
1b037c2
fea6365
b04096b
5a70ecb
6e80c7f
30c1dd4
86f8133
845dd47
40519ec
af9d3fc
a868e4c
54e213b
81407fc
d4fb9bc
42990a2
2dd360f
0aeb70c
aae0d2a
f2f0a45
fecec39
5cf84bc
5a8c9d6
8fefdea
a2c1910
a42b308
6f13c03
32864c6
b3a92a1
1628f5a
f3edc61
e7c17a1
c114d38
b26207d
14a3666
4c177d7
a8f3697
e7f804e
23e5773
6c469a5
a18c549
88b899b
9134465
5229d7e
efbd31f
3c8823e
adb5258
b858b53
3ee1bbb
5cbce25
dd64513
a72ac99
ae3117a
8832e79
78e4777
932af13
a23ad9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not going to require any changes here since this is only invoked in debug cases, but note that dynamic configs are not guaranteed to have the same labels, or even the same modes. Note that the Lao labels, for example that I asked you to test against, do not have the translation "Gas Car Shared Ride".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some notes here about the particular dynamic config that this works with. Because we have at least two production (non-example) dynamic configs now (Laos and CA e-bike) and the second is even in English. So people might be confused while debugging and not know why this doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment by mentioning the print statements for debugging mode are specifically designed in consideration with https://github.com/e-mission/nrel-openpath-deploy-configs/blob/main/configs/dev-emulator-program.nrel-op.json.