Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to guess slider valve types #577

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

dlohmeier
Copy link
Collaborator

No description provided.

@dlohmeier dlohmeier requested a review from EPrade December 4, 2023 09:50
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (6f67869) 85.11% compared to head (6977435) 85.01%.

Files Patch % Lines
pandapipes/converter/stanet/table_creation.py 73.07% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #577      +/-   ##
===========================================
- Coverage    85.11%   85.01%   -0.10%     
===========================================
  Files           90       90              
  Lines         6173     6200      +27     
===========================================
+ Hits          5254     5271      +17     
- Misses         919      929      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonRubenDrauz SimonRubenDrauz merged commit d1e61ad into e2nIEE:develop Dec 19, 2023
12 of 14 checks passed
@dlohmeier dlohmeier deleted the stanet_converter_sv_types branch February 20, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants