Skip to content

Commit

Permalink
Add clarification comment in TopicDataType::compute_key(SerializedPay…
Browse files Browse the repository at this point in the history
…load_t, ...)

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
  • Loading branch information
LuciaEchevarria99 committed Sep 9, 2024
1 parent f854ba0 commit c6ce464
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions ddspipe_participants/src/cpp/types/dds/TopicDataType.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,11 @@ bool TopicDataType::compute_key(
fastdds::rtps::InstanceHandle_t& handle,
bool /* = false */)
{
// NOTE: This method returns false because Fast DDS always sends the KEY_HASH in inline QoS.
// As a result, the reader will never call this method when communicating with a Fast DDS writer.
// This would only be needed if receiving data from another DDS vendor that omits the KEY_HASH.
// Workaround in that case (different DDS vendor that omits KEY_HASH): set expects_inline_qos_ to
// true in DataReaderQos
return false;
}

Expand Down

0 comments on commit c6ce464

Please sign in to comment.