Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty XTSAN tests list #107

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Empty XTSAN tests list #107

merged 1 commit into from
Jul 18, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

Up to eProsima/eProsima-CI#77 , almost every test using Fast-DDS was reporting multiple TSAN warnings that were in fact false positives. For this reason these tests were categorized as flaky when running the TSAN action, but after the update in eProsima-CI they should no longer fail.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.09%. Comparing base (1402c3a) to head (f2caf10).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   34.10%   34.09%   -0.02%     
==========================================
  Files         154      154              
  Lines        7875     7875              
  Branches     3516     3516              
==========================================
- Hits         2686     2685       -1     
  Misses       3276     3276              
- Partials     1913     1914       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

irenebm
irenebm previously approved these changes May 16, 2024
Copy link
Member

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@irenebm irenebm merged commit 2bf6aff into main Jul 18, 2024
17 checks passed
@irenebm irenebm deleted the feature/remove-xtsan branch July 18, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants