New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20509] Update repository for Fast DDS 3.0.0 compatibility #111

Merged

rsanchez15 merged 53 commits into main from integration/bump-3.0.0

Sep 10, 2024

Contributor

LuciaEchevarria99 commented Apr 22, 2024 •

edited by juanlofer-eprosima

Loading

Merge after:

Fast-DDS:

dev-utils:

Update repository for Fast DDS 3.0.0 compatibility dev-utils#101

DDS-Pipe:

LuciaEchevarria99 had a problem deploying to codecov

April 22, 2024 05:50

— with

GitHub Actions Failure

LuciaEchevarria99 had a problem deploying to codecov

April 27, 2024 10:39

— with

GitHub Actions Failure

rsanchez15 changed the title ~~Update repository for FastDDS 3.0.0 compatibility~~ Update repository for Fast DDS 3.0.0 compatibility

juanlofer-eprosima requested changes

View reviewed changes

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

LuciaEchevarria99 mentioned this pull request

Update repository for Fast DDS 3.0.0 compatibility eProsima/DDS-Record-Replay#141

Closed

LuciaEchevarria99 had a problem deploying to codecov

May 17, 2024 09:01

— with

GitHub Actions Failure

LuciaEchevarria99 force-pushed the integration/bump-3.0.0 branch from e08275f to ec66d16 Compare

May 17, 2024 09:04

LuciaEchevarria99 had a problem deploying to codecov

May 17, 2024 09:04

— with

GitHub Actions Failure

LuciaEchevarria99 changed the base branch from main to ci/bump-v3

May 17, 2024 09:04

LuciaEchevarria99 had a problem deploying to codecov

May 20, 2024 13:14

— with

GitHub Actions Failure

LuciaEchevarria99 mentioned this pull request

[20509] Update repository for Fast DDS 3.0.0 compatibility eProsima/Fast-DDS-spy#86

Merged

LuciaEchevarria99 had a problem deploying to codecov

May 27, 2024 06:43

— with

GitHub Actions Failure

LuciaEchevarria99 had a problem deploying to codecov

May 29, 2024 06:21

— with

GitHub Actions Failure

LuciaEchevarria99 had a problem deploying to codecov

June 3, 2024 13:28

— with

GitHub Actions Failure

rsanchez15 changed the base branch from ci/bump-v3 to 1.x-devel

June 4, 2024 07:21

Tempate suggested changes

View reviewed changes

Contributor

Tempate left a comment

Good job! Thanks for your hard work. Keep it up 🥇

ddspipe_core/src/cpp/types/topic/dds/DdsTopic.cpp Outdated Show resolved Hide resolved

..._participants/include/ddspipe_participants/participant/dynamic_types/DynTypesParticipant.hpp Outdated Show resolved Hide resolved

ddspipe_participants/include/ddspipe_participants/participant/dds/CommonParticipant.hpp Outdated Show resolved Hide resolved

ddspipe_participants/src/cpp/participant/dds/CommonParticipant.cpp Outdated Show resolved Hide resolved

ddspipe_participants/src/cpp/participant/dynamic_types/DynTypesParticipant.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_idl.cpp Outdated Show resolved Hide resolved

ddspipe_core/src/cpp/types/dynamic_types/schema_msg.cpp Show resolved Hide resolved

LuciaEchevarria99 force-pushed the integration/bump-3.0.0 branch from 72b790f to e028507 Compare

June 5, 2024 07:46

LuciaEchevarria99 had a problem deploying to codecov

June 5, 2024 07:46

— with

GitHub Actions Failure

LuciaEchevarria99 had a problem deploying to codecov

June 11, 2024 11:37

— with

GitHub Actions Failure

Tempate reviewed

View reviewed changes

ddspipe_participants/src/cpp/participant/dynamic_types/DynTypesParticipant.cpp Outdated Show resolved Hide resolved

LuciaEchevarria99 had a problem deploying to codecov

June 17, 2024 14:03

— with

GitHub Actions Failure

LuciaEchevarria99 mentioned this pull request

[20509] Update repository for Fast DDS 3.0.0 compatibility eProsima/DDS-Record-Replay#148

Merged

LuciaEchevarria99 changed the title ~~Update repository for Fast DDS 3.0.0 compatibility~~ [20509] Update repository for Fast DDS 3.0.0 compatibility

LuciaEchevarria99 had a problem deploying to codecov

June 20, 2024 12:45

— with

GitHub Actions Failure

Tempate suggested changes

View reviewed changes

Contributor

Tempate left a comment

Please make sure to find and remove the const_casts made explicitly to be able to write. They aren't necessary any more.

LuciaEchevarria99 had a problem deploying to codecov

June 26, 2024 07:48

— with

GitHub Actions Failure

LuciaEchevarria99 had a problem deploying to codecov

July 3, 2024 10:54

— with

GitHub Actions Failure

LuciaEchevarria99 had a problem deploying to codecov

July 11, 2024 13:22

— with

GitHub Actions Failure

Carlosespicur reviewed

View reviewed changes

ddspipe_core/include/ddspipe_core/efficiency/payload/PayloadPool.hpp Outdated Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/efficiency/payload/PayloadPool.hpp Outdated Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/efficiency/payload/PayloadPool.hpp Outdated Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/logging/DdsLogConsumer.hpp Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/monitoring/producers/StatusMonitorProducer.hpp Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/monitoring/producers/TopicsMonitorProducer.hpp Outdated Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/monitoring/producers/TopicsMonitorProducer.hpp Outdated Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/types/dds/DomainId.hpp Outdated Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/types/dds/Payload.hpp Show resolved Hide resolved

ddspipe_core/include/ddspipe_core/types/dds/SpecificEndpointQoS.hpp Outdated Show resolved Hide resolved

Carlosespicur reviewed

View reviewed changes

ddspipe_core/src/cpp/communication/dds/Track.cpp Show resolved Hide resolved

juanlofer-eprosima and others added 14 commits

September 10, 2024 08:29


          Accept v6 interfaces and interface names in whitelist (#128)

3d370e7

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>


          Make DiscoveryServer servers' guid prefix optional (#129)

5cce977

* Make DiscoveryServer servers' guid prefix optional

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Raise YAML reader version

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* BONUS: improve participant discovery traces

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

---------

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>


          Add missing suggested changes

1a0295c

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Correct type_kind_to_str output for TK_CHAR8 case

80cca3a

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Remove unnecessary CacheChange include

2df989c

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Implement add_qos_properties_ in reckon_participant_qos_

9534f79

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Remove Fast-DDS API ReturnCode explanation in PayloadPoolMediator::write

44c01d7

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Change name ip_configuration -> initial_peers_configuration

7e12adc

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Change name ds_configuration -> discovery_server_configuration

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Use dynamic_pointer_cast instead of static_pointer_cast in reckon_par…

74daf38

…ticipant_attributes_

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Change function descriptions in CommonParticipant

aac932c

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          CHange char sequence message in tests

225fdb6

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Add clarification comment in TopicDataType::compute_key(SerializedPay…

aa1a682

…load_t, ...)

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>


          Fix YamlGetEntityGuidPrefixTest.get_guidprefix_explicitly test

fa147dc

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

LuciaEchevarria99 force-pushed the integration/bump-3.0.0 branch from 0a7ee4b to fa147dc Compare

September 10, 2024 06:29

LuciaEchevarria99 temporarily deployed to codecov

September 10, 2024 06:29

— with

GitHub Actions Inactive


          Add comment clarifying the order of TypeIdentifiers (complete and min…

d2fa3fa

…imal) in DdsTopic.type_identifiers

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

LuciaEchevarria99 temporarily deployed to codecov

September 10, 2024 09:59

— with

GitHub Actions Inactive


          Fix Windows compilation

3012a05

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

LuciaEchevarria99 temporarily deployed to codecov

September 10, 2024 10:00

— with

GitHub Actions Inactive


          Uncrustify

75062c8

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

LuciaEchevarria99 temporarily deployed to codecov

September 10, 2024 10:13

— with

GitHub Actions Inactive


          Check if ParticipantConfiguration is nullptr after cast in reckon_par…

b0c8072

…ticipant_attributes_

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

LuciaEchevarria99 temporarily deployed to codecov

September 10, 2024 12:34

— with

GitHub Actions Inactive


          Fix uncrustify

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

LuciaEchevarria99 temporarily deployed to codecov

September 10, 2024 12:39

— with

GitHub Actions Inactive

rsanchez15 merged commit 7fff9e9 into main

16 of 17 checks passed

rsanchez15 deleted the integration/bump-3.0.0 branch

September 10, 2024 14:00

juanlofer-eprosima restored the integration/bump-3.0.0 branch

September 13, 2024 07:28

juanlofer-eprosima deleted the integration/bump-3.0.0 branch

September 13, 2024 07:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet