Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'addresses' tag from Discovery Server connection-addresses #131

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

No description provided.

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 37.86%. Comparing base (7fff9e9) to head (3530efa).

Files with missing lines Patch % Lines
...pp/participant/rtps/DiscoveryServerParticipant.cpp 5.88% 16 Missing ⚠️
...ration/DiscoveryServerParticipantConfiguration.cpp 0.00% 1 Missing ⚠️
ddspipe_yaml/src/cpp/YamlReader_participants.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   36.77%   37.86%   +1.08%     
==========================================
  Files         169      152      -17     
  Lines       11382     6956    -4426     
  Branches     5190     2764    -2426     
==========================================
- Hits         4186     2634    -1552     
+ Misses       4482     2937    -1545     
+ Partials     2714     1385    -1329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsanchez15 rsanchez15 merged commit 45a0234 into main Sep 13, 2024
17 checks passed
@rsanchez15 rsanchez15 deleted the feature/remove-ds-connection-address branch September 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants