Add DLL Export to Protected Methods in CommonParticipant and child Classes #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rticipant Classes Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
LuciaEchevarria99
temporarily deployed
to
codecov
GitHub Actions
Inactive
LuciaEchevarria99
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 36.53% 37.86% +1.33%
==========================================
Files 169 152 -17
Lines 11542 6956 -4586
Branches 5277 2764 -2513
==========================================
- Hits 4217 2634 -1583
+ Misses 4580 2937 -1643
+ Partials 2745 1385 -1360 ☔ View full report in Codecov by Sentry. |
…ticipant Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
LuciaEchevarria99
temporarily deployed
to
codecov
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces the addition of
DDSPIPE_PARTICIPANTS_DllAPIto the protected methods in theCommonParticipantand its child classes. By exporting these methods, we ensure they are properly exposed when building shared libraries, allowing child classes of external modules to access these functionalities.