Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21380] Support setting value to an enumeration literal using annotation @value #379

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 17, 2024

Description

This PR adds support for settting a value to an enumeration literal. For example:

enum MyEnum
{
    @value(-3)
    ENUM_VALUE1,
    @value(0)
    ENUM_VALUE2
};

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Support setting value to an enumeration literal using annotation @value [21380] Support setting value to an enumeration literal using annotation @value Jul 17, 2024
@EduPonz EduPonz added this to the v4.0.0 milestone Jul 18, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I'd add a test in dds-types-test though

@richiware richiware requested a review from EduPonz July 26, 2024 09:04
@richiware richiware requested review from EduPonz and removed request for EduPonz July 26, 2024 09:06
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 26, 2024
@rsanchez15 rsanchez15 modified the milestones: v4.0.0, v4.0.1 Jul 26, 2024
@rsanchez15 rsanchez15 modified the milestones: v4.0.1, v4.0.2 Sep 5, 2024
@richiware richiware requested review from MiguelCompany and removed request for EduPonz September 9, 2024 10:42
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a PR to the documentation

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware merged commit f24cb50 into master Sep 26, 2024
4 checks passed
@richiware richiware deleted the bugfix/21379 branch September 26, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants