-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21380] Support setting value to an enumeration literal using annotation @value #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
changed the title
Support setting value to an enumeration literal using annotation @value
[21380] Support setting value to an enumeration literal using annotation @value
Jul 17, 2024
EduPonz
suggested changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, I'd add a test in dds-types-test though
richiware
force-pushed
the
bugfix/21379
branch
from
September 9, 2024 10:42
7111aea
to
f787d48
Compare
richiware
requested review from
MiguelCompany
and removed request for
EduPonz
September 9, 2024 10:42
MiguelCompany
requested changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a PR to the documentation
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
richiware
force-pushed
the
bugfix/21379
branch
from
September 24, 2024 09:31
f787d48
to
f03cee0
Compare
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
7 tasks
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
MiguelCompany
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for settting a value to an enumeration literal. For example:
Depends on:
@value
annotation dds-types-test#36@value
annotation Fast-DDS#5109Contributor Checklist
Reviewer Checklist