Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21788] Improve equality operator for unions #409

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 3, 2024

Description

Currently the equality operator might return false when comparing a union initialized with its implicit default value and the same generated by another middleware. This is because we expects the discriminator's value should be equal, but it is not mandatory. This PR fixes this.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Improve equality operator for unions [21788] Improve equality operator for unions Oct 3, 2024
@MiguelCompany MiguelCompany self-requested a review October 3, 2024 05:59
@MiguelCompany MiguelCompany added this to the v2.5.4 milestone Oct 3, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 3, 2024
@MiguelCompany MiguelCompany modified the milestones: v2.5.4, v4.0.2 Oct 3, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 3, 2024
@richiware richiware merged commit c85b6d7 into master Oct 3, 2024
4 checks passed
@richiware richiware deleted the bugfix/21786 branch October 3, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants