Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21758] Fix structs TypeObject registration with -typeros2 option #414

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Oct 22, 2024

Description

Structs are currently registered in the type object registry with their scoped name, instead of using their ROS 2 scoped name when typeros2 is provided. As a consequence, there is a discrepancy between the name with which the type is registered in the type object registry and the name embedded in the generated TypeSupport.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@richiware richiware added this to the v4.0.3 milestone Oct 23, 2024
@richiware richiware self-requested a review October 23, 2024 10:28
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 23, 2024
@richiware richiware merged commit fc9928b into master Oct 25, 2024
4 checks passed
@richiware richiware deleted the bugfix/ros2-types-registration branch October 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants