Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22043] Call Cdr::set_dds_cdr_options() when TypeSupport encodes #417

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[22043] Call Cdr::set_dds_cdr_options() when TypeSupport encodes #417

merged 1 commit into from
Nov 5, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 31, 2024 •
edited by MiguelCompany
Loading

Description

According with new fastcdr API usage, the generated code should call Cdr::set_dds_cdr_options().

Depends on:

@Mergifyio backport 3.3.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #22039. Call fastcdr::set_dds_cdr_options when encoding
1c3fc73 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware added this to the v4.0.3 milestone Oct 31, 2024
@richiware richiware changed the title Call Cdr::set_dds_cdr_options() when TypeSupport encodes [22043] Call Cdr::set_dds_cdr_options() when TypeSupport encodes Oct 31, 2024
@MiguelCompany MiguelCompany self-requested a review November 5, 2024 10:40
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 5, 2024
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany November 5, 2024 10:41
MiguelCompany
MiguelCompany approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware richiware merged commit b3cf046 into master Nov 5, 2024
4 of 6 checks passed
@richiware richiware deleted the feature/set-dds-options branch November 5, 2024 13:08
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.3.x

@mergify Mergify
Copy link

mergify bot commented Nov 5, 2024 •
edited
Loading

backport 3.3.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 5, 2024
@richiware @mergify
Call Cdr::set_dds_cdr_options() when TypeSupport encodes (#417)
bfff6ba 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
(cherry picked from commit b3cf046)
@mergify mergify bot mentioned this pull request Nov 5, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany