Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19778][20296] Add netmask filter transport configuration + interface allowlist and blocklist #659

Merged
merged 5 commits into from
Mar 17, 2024
Merged

[19778][20296] Add netmask filter transport configuration + interface allowlist and blocklist #659

merged 5 commits into from
Mar 17, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima mentioned this pull request Feb 7, 2024
Merged
11 tasks
@EduPonz EduPonz added this to the v2.14.0 milestone Feb 14, 2024
@juanlofer-eprosima juanlofer-eprosima changed the title [19778] Add netmask filter transport configuration + interface blocklist [19778][20296] Add netmask filter transport configuration + interface blocklist Mar 1, 2024
Mario-DL
Mario-DL requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got confused with the Fast DDS PR

Mario-DL
Mario-DL requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the documentation of the feature. The explanation is clear and reachable.
Leaving some suggestions.

docs/fastdds/transport/interfaces.rst Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Outdated Show resolved Hide resolved
docs/fastdds/transport/interfaces.rst Show resolved Hide resolved
docs/fastdds/transport/whitelist.rst Outdated Show resolved Hide resolved
@juanlofer-eprosima juanlofer-eprosima changed the title [19778][20296] Add netmask filter transport configuration + interface blocklist [19778][20296] Add netmask filter transport configuration + interface allowlist and blocklist Mar 11, 2024
@juanlofer-eprosima
Add documentation for interfaces configuration (netmask_filter/allowl…
2c4b7dd 
…ist/blocklist)

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@juanlofer-eprosima
Update after Fast-DDS branch changes
513525e 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@juanlofer-eprosima
Apply suggestions
e282951 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Mario-DL
Mario-DL reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, leaving only one conversation openned to be addressed

@Mario-DL
Copy link
Member

@richiprosima please test docs

@juanlofer-eprosima
Minor changes
4ae2acb 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
@juanlofer-eprosima
Add example with explicit NetworkInterface construction + minor changes
6e35954 
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Mario-DL
Mario-DL approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL
Copy link
Member

@richiprosima please test docs

@EduPonz EduPonz merged commit 079dde6 into master Mar 17, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/netmask-filter branch March 17, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juanlofer-eprosima @Mario-DL @EduPonz