Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20568] Adjust for removing all redundant headers from include/fastrtps #737

Merged
merged 1 commit into from
May 20, 2024
Merged

[20568] Adjust for removing all redundant headers from include/fastrtps #737

merged 1 commit into from
May 20, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 27, 2024 •
edited
Loading

Description

This PR adds support for:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@EduPonz EduPonz added this to the v3.0.0 milestone Mar 27, 2024
@EduPonz EduPonz mentioned this pull request Mar 27, 2024
Merged
9 tasks
@elianalf
Copy link
Contributor

@richiprosima please test_3 this

elianalf
elianalf previously approved these changes Mar 27, 2024
View reviewed changes
@EduPonz EduPonz force-pushed the feature/remove_from_include_fastrtps branch from 6be4a7b to ac33e9d Compare April 24, 2024 05:33
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from 3fbf8f1 to 497ab7c Compare May 14, 2024 07:05
Base automatically changed from 3.0.x-devel to master May 14, 2024 07:19
@EduPonz EduPonz dismissed elianalf’s stale review May 14, 2024 07:19

The base branch was changed.

@EduPonz EduPonz force-pushed the feature/remove_from_include_fastrtps branch from ac33e9d to 2ffe31c Compare May 16, 2024 05:49
@EduPonz
Copy link
Author

EduPonz commented May 16, 2024

@richiprosima please test_3 this

@EduPonz
Refs #20568: Fix CodeTester build
a62b911 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/remove_from_include_fastrtps branch from 2ffe31c to a62b911 Compare May 17, 2024 11:46
@elianalf
Copy link
Contributor

@richiprosima please test_3 this

@EduPonz EduPonz merged commit 19c3a78 into master May 20, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/remove_from_include_fastrtps branch May 20, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @elianalf