Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20567] Add ReplierQos and RequesterQos #113

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Mar 26, 2024

Description

This PR adds support for:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.0.0 milestone Mar 26, 2024
@EduPonz EduPonz changed the title Refs #20567: Add ReplierQos and RequesterQos [20567] Add ReplierQos and RequesterQos Mar 26, 2024
Copy link
Contributor

@elianalf elianalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Green CI, which is running here with the right FastDDS branch
I approved it even though I think we shell remove from the repository all the .i file not included in fastdds.i:

  • utils/DBQueue.i
  • utils/TimeConversion.i
  • utils/StringMatching.i
  • Liveliness implementation related API
  • rtps/builtin/BuiltinProtocols.i
  • rtps/messages/MessageReceiver.i
  • utils/Semaphore.i
  • All discovery implementation related API
  • attributes/SubscriberAttributes.i
  • attributes/PublisherAttributes.i
  • attributes/RequesterAttributes.i
  • attributes/ReplierAttributes.i
  • attributes/ParticipantAttributes.i

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Copy link
Author

EduPonz commented Mar 26, 2024

I've applied the suggestions. CI running here

@EduPonz EduPonz merged commit bc90ddb into 3.0.x-devel Mar 27, 2024
2 of 6 checks passed
@EduPonz EduPonz deleted the feature/make_private_from_include_fastrtps branch March 27, 2024 07:29
JLBuenoLopez pushed a commit that referenced this pull request Apr 3, 2024
* Refs #20567: Add ReplierQos and RequesterQos

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20567: Apply Eliana's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz added a commit that referenced this pull request May 14, 2024
* Refs #20567: Add ReplierQos and RequesterQos

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20567: Apply Eliana's suggestions

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants