Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21120] Adjust for API changes in RTPS reader APIs #140

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[21120] Adjust for API changes in RTPS reader APIs #140

merged 3 commits into from
Jun 12, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jun 12, 2024 •
edited by MiguelCompany
Loading

Description

This PR adjusts for the changes introduced in:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #21120: Adjust for API changes
594d958 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21120: Correct typo
26deb18 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.0.0 milestone Jun 12, 2024
@MiguelCompany
Refs #21120. Force fastdds log consumer to STDOUT.
c6a2528 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
MiguelCompany approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jun 12, 2024
@EduPonz EduPonz merged commit 7b27cf7 into main Jun 12, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/rtps_reader_refactor branch June 12, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EduPonz @MiguelCompany