Skip to content

Commit

Permalink
Refs #20821: Apply suggestions: Make persistenteWriter private
Browse files Browse the repository at this point in the history
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
  • Loading branch information
elianalf committed May 30, 2024
1 parent fd6292d commit 382220e
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include <fastdds/rtps/history/ReaderHistory.h>
#include <fastdds/rtps/reader/RTPSReader.h>


#include <rtps/builtin/discovery/endpoint/EDPServer.hpp>
#include <rtps/builtin/discovery/participant/PDPServer.hpp>
#include <rtps/writer/StatefulWriter.hpp>
Expand Down
2 changes: 1 addition & 1 deletion src/cpp/rtps/writer/PersistentWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*
*/

#include <fastdds/rtps/writer/PersistentWriter.h>
#include <rtps/writer/PersistentWriter.hpp>

#include <fastdds/rtps/history/WriterHistory.h>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,16 @@
// limitations under the License.

/**
* @file PersistentWriter.h
* @file PersistentWriter.hpp
*/
#ifndef _FASTDDS_RTPS_PERSISTENTWRITER_H_
#define _FASTDDS_RTPS_PERSISTENTWRITER_H_

#include <fastdds/rtps/writer/RTPSWriter.h>
#ifndef RTPS_WRITER__PERSISTENTWRITER_HPP
#define RTPS_WRITER__PERSISTENTWRITER_HPP

#include <string>

#include <fastdds/rtps/writer/RTPSWriter.h>

#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

namespace eprosima {
Expand Down Expand Up @@ -77,4 +79,4 @@ class PersistentWriter
} // namespace eprosima

#endif // ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC
#endif /* _FASTDDS_RTPS_PERSISTENTWRITER_H_ */
#endif /* RTPS_WRITER__PERSISTENTWRITER_HPP */
4 changes: 1 addition & 3 deletions src/cpp/rtps/writer/StatefulPersistentWriter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@

#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC


#include <fastdds/rtps/writer/PersistentWriter.h>

#include <rtps/writer/PersistentWriter.hpp>
#include <rtps/writer/StatefulWriter.hpp>

namespace eprosima {
Expand Down
3 changes: 1 addition & 2 deletions src/cpp/rtps/writer/StatelessPersistentWriter.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@

#ifndef DOXYGEN_SHOULD_SKIP_THIS_PUBLIC

#include <fastdds/rtps/writer/PersistentWriter.h>

#include <rtps/writer/PersistentWriter.hpp>
#include <rtps/writer/StatelessWriter.hpp>

namespace eprosima {
Expand Down
2 changes: 0 additions & 2 deletions test/unittest/dds/publisher/DataWriterTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,9 @@
#include <fastdds/dds/subscriber/qos/SubscriberQos.hpp>
#include <fastdds/dds/subscriber/Subscriber.hpp>
#include <fastdds/publisher/DataWriterImpl.hpp>
#include <fastdds/rtps/writer/RTPSWriter.h>

#include "../../common/CustomPayloadPool.hpp"
#include "../../logging/mock/MockConsumer.h"
#include <rtps/writer/StatefulWriter.hpp>

namespace eprosima {
namespace fastdds {
Expand Down

0 comments on commit 382220e

Please sign in to comment.