Refs #21077: Make Endpoints Properties unmutable

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
eProsima · May 23, 2024 · 58a688b · 58a688b
1 parent 9eaef17
commit 58a688b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/cpp/fastdds/publisher/DataWriterImpl.cpp b/src/cpp/fastdds/publisher/DataWriterImpl.cpp
@@ -2000,6 +2000,12 @@ bool DataWriterImpl::can_qos_be_updated(
         EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK,
                 "Only the period of Positive ACKs can be changed after the creation of a DataWriter.");
     }
+    if (!(to.properties() == from.properties()))
+    {
+        updatable = false;
+        EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PropertyPolicyQos cannot be changed after the DataWriter is enabled.");
+    }
+
     return updatable;
 }
 

diff --git a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp
@@ -1643,7 +1643,12 @@ bool DataReaderImpl::can_qos_be_updated(
     {
         updatable = false;
         EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK,
-                "data_sharing_listener_thread cannot be changed after the DataReader is enabled");
+                "data_sharing_listener_thread cannot be changed after the DataReader is enabled.");
+    }
+    if (!(to.properties() == from.properties()))
+    {
+        updatable = false;
+        EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PropertyPolicyQos cannot be changed after the DataReader is enabled.");
     }
     return updatable;
 }