Fix hidden overloaded virtual methods (#4625)

* Refs #20592: Fix for test



* Refs #20592: Fix for examples



* Refs #20592: Add more warning flags to Ubuntu CI



* Refs #20592: Remove default values on overloaded PDPClient::announceParticipantState



---------


(cherry picked from commit 63cc242)

Fix conflicts

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

.github/workflows/reusable-ubuntu-ci.yml

@@ -105,7 +105,7 @@ jobs:
           colcon_meta_file: ${{ github.workspace }}/src/fastrtps/.github/workflows/config/ci.meta
           colcon_build_args: ${{ inputs.colcon-args }}
           cmake_args: ${{ inputs.cmake-args }}
-          cmake_args_default: -DCMAKE_CXX_FLAGS="-Werror -Wall"
+          cmake_args_default: -DCMAKE_CXX_FLAGS="-Werror -Wall -Wextra -Wpedantic -Wunused-value -Woverloaded-virtual" -DFASTDDS_EXAMPLE_TESTS=ON
           cmake_build_type: ${{ matrix.cmake-build-type }}
           workspace: ${{ github.workspace }}
 

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerPublisher.h

@@ -105,6 +105,8 @@ class HelloWorldPublisher
 
     private:
 
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
+
         //! Number of DataReaders matched to the associated DataWriter
         std::atomic<std::uint32_t> matched_;
     }

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerServer.h

@@ -84,6 +84,10 @@ class DiscoveryServer
         void on_participant_discovery(
                 eprosima::fastdds::dds::DomainParticipant* /*participant*/,
                 eprosima::fastrtps::rtps::ParticipantDiscoveryInfo&& info) override;
+
+    private:
+
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
     }
     listener_;
 

examples/cpp/dds/DiscoveryServerExample/DiscoveryServerSubscriber.h

@@ -112,6 +112,8 @@ class HelloWorldSubscriber
 
     private:
 
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
+
         HelloWorld hello_;
 
         //! Number of DataWriters matched to the associated DataReader

examples/cpp/dds/LivelinessQoS/LivelinessSubscriber.h

@@ -101,9 +101,15 @@ class LivelinessSubscriber
 
     class PartListener : public eprosima::fastdds::dds::DomainParticipantListener
     {
+    public:
+
         virtual void on_participant_discovery(
                 eprosima::fastdds::dds::DomainParticipant* participant,
                 eprosima::fastrtps::rtps::ParticipantDiscoveryInfo&& info) override;
+
+    private:
+
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
     };
 
     PartListener part_listener_;

examples/cpp/rtps/Persistent/TestReaderPersistent.h

@@ -66,6 +66,10 @@ class TestReaderPersistent
 
         uint32_t n_received;
         uint32_t n_matched;
+
+    private:
+
+        using eprosima::fastrtps::rtps::ReaderListener::onReaderMatched;
     }
     m_listener;
 };

examples/cpp/rtps/Persistent/TestWriterPersistent.h

@@ -62,6 +62,10 @@ class TestWriterPersistent
         }
 
         int n_matched;
+
+    private:
+
+        using eprosima::fastrtps::rtps::WriterListener::onWriterMatched;
     }
     m_listener;
 };

examples/cpp/rtps/Registered/TestReaderRegistered.h

@@ -66,6 +66,10 @@ class TestReaderRegistered
 
         uint32_t n_received;
         uint32_t n_matched;
+
+    private:
+
+        using eprosima::fastrtps::rtps::ReaderListener::onReaderMatched;
     }
     m_listener;
 };

examples/cpp/rtps/Registered/TestWriterRegistered.h

@@ -62,6 +62,10 @@ class TestWriterRegistered
         }
 
         int n_matched;
+
+    private:
+
+        using eprosima::fastrtps::rtps::WriterListener::onWriterMatched;
     }
     m_listener;
 };

include/fastrtps/subscriber/SubscriberHistory.h

@@ -179,6 +179,10 @@ class SubscriberHistory : public rtps::ReaderHistory
 
 private:
 
+    using rtps::ReaderHistory::completed_change;
+    using rtps::ReaderHistory::received_change;
+    using rtps::ReaderHistory::remove_change_nts;
+
     using t_m_Inst_Caches = std::map<rtps::InstanceHandle_t, KeyedChanges>;
 
     //!Map where keys are instance handles and values vectors of cache changes

src/cpp/fastdds/domain/DomainParticipantImpl.hpp

@@ -662,6 +662,10 @@ class DomainParticipantImpl
             bool on_guard_;
         };
 
+        using fastrtps::rtps::RTPSParticipantListener::onParticipantDiscovery;
+        using fastrtps::rtps::RTPSParticipantListener::onReaderDiscovery;
+        using fastrtps::rtps::RTPSParticipantListener::onWriterDiscovery;
+
     public:
 
         MyRTPSParticipantListener(

src/cpp/fastdds/publisher/DataWriterImpl.hpp

@@ -459,6 +459,10 @@ class DataWriterImpl : protected rtps::IReaderDataFilter
 #endif //FASTDDS_STATISTICS
 
         DataWriterImpl* data_writer_;
+
+    private:
+
+        using fastrtps::rtps::WriterListener::onWriterMatched;
     }
     writer_listener_;
 

src/cpp/fastdds/subscriber/DataReaderImpl.hpp

@@ -451,6 +451,10 @@ class DataReaderImpl
 #endif //FASTDDS_STATISTICS
 
         DataReaderImpl* data_reader_;
+
+    private:
+
+        using fastrtps::rtps::ReaderListener::onReaderMatched;
     }
     reader_listener_;
 

src/cpp/fastrtps_deprecated/participant/ParticipantImpl.h

@@ -233,6 +233,12 @@ class ParticipantImpl
 
         ParticipantImpl* mp_participantimpl;
 
+    private:
+
+        using rtps::RTPSParticipantListener::onParticipantDiscovery;
+        using rtps::RTPSParticipantListener::onReaderDiscovery;
+        using rtps::RTPSParticipantListener::onWriterDiscovery;
+
     }
     m_rtps_listener;
 

src/cpp/fastrtps_deprecated/publisher/PublisherImpl.h

@@ -243,6 +243,10 @@ class PublisherImpl
                 const LivelinessLostStatus& status) override;
 
         PublisherImpl* mp_publisherImpl;
+
+    private:
+
+        using rtps::WriterListener::onWriterMatched;
     }
     m_writerListener;
 

src/cpp/fastrtps_deprecated/subscriber/SubscriberImpl.h

@@ -221,6 +221,10 @@ class SubscriberImpl
                 rtps::RTPSReader* reader,
                 const LivelinessChangedStatus& status) override;
         SubscriberImpl* mp_subscriberImpl;
+
+    private:
+
+        using rtps::ReaderListener::onReaderMatched;
     }
     m_readerListener;
 

src/cpp/rtps/DataSharing/ReaderPool.hpp

@@ -284,6 +284,8 @@ class ReaderPool : public DataSharingPayloadPool
 
 private:
 
+    using DataSharingPayloadPool::init_shared_memory;
+
     bool is_volatile_;              //< Whether the reader is volatile or not
     uint64_t next_payload_;         //< Index of the next history position to read
     SequenceNumber_t last_sn_;      //< Sequence number of the last read payload

src/cpp/rtps/DataSharing/WriterPool.hpp

@@ -353,6 +353,8 @@ class WriterPool : public DataSharingPayloadPool
 
 private:
 
+    using DataSharingPayloadPool::init_shared_memory;
+
     octet* payloads_pool_;          //< Shared pool of payloads
 
     uint32_t max_data_size_;        //< Maximum size of the serialized payload data

src/cpp/rtps/builtin/discovery/participant/PDPClient.h

@@ -114,8 +114,8 @@ class PDPClient : public PDP
      */
     void announceParticipantState(
             bool new_change,
-            bool dispose = false,
-            WriteParams& wparams = WriteParams::WRITE_PARAM_DEFAULT) override;
+            bool dispose,
+            WriteParams& wparams) override;
 
     /**
      * These methods wouldn't be needed under perfect server operation
@@ -178,6 +178,8 @@ class PDPClient : public PDP
 
 private:
 
+    using fastrtps::rtps::PDP::announceParticipantState;
+
     /**
      * Manually match the local PDP reader with the PDP writer of a given server. The function is
      * not thread safe (nts) in the sense that it does not take the PDP mutex. It does however take

src/cpp/rtps/builtin/discovery/participant/PDPServer.hpp

@@ -317,6 +317,8 @@ class PDPServer : public fastrtps::rtps::PDP
 
 private:
 
+    using fastrtps::rtps::PDP::announceParticipantState;
+
 #if HAVE_SECURITY
     /**
      * Returns whether discovery should be secured

src/cpp/rtps/builtin/discovery/participant/timedevent/DSClientEvent.cpp

@@ -90,7 +90,8 @@ bool DSClientEvent::event()
         // This marks to announceParticipantState that the announcement is only meant for missing servers,
         // so it is not a periodic announcement
         mp_PDP->_serverPing = true;
-        mp_PDP->announceParticipantState(false);
+        WriteParams __wp = WriteParams::write_params_default();
+        mp_PDP->announceParticipantState(false, false, __wp);
         EPROSIMA_LOG_INFO(CLIENT_PDP_THREAD,
                 "Client " << mp_PDP->getRTPSParticipant()->getGuid() << " PDP announcement");
     }

src/cpp/rtps/history/BasicPayloadPool_impl/Base.hpp

@@ -18,6 +18,8 @@
 
 class BaseImpl : public IPayloadPool
 {
+public:
+
     bool get_payload(
             uint32_t size,
             CacheChange_t& cache_change) override

src/cpp/rtps/history/BasicPayloadPool_impl/PreallocatedWithRealloc.hpp

@@ -39,5 +39,7 @@ class Impl<PREALLOCATED_WITH_REALLOC_MEMORY_MODE> : public BaseImpl
 
 private:
 
+    using BaseImpl::get_payload;
+
     uint32_t min_payload_size_;
 };

src/cpp/rtps/history/TopicPayloadPool_impl/Dynamic.hpp

@@ -86,6 +86,10 @@ class DynamicTopicPayloadPool : public TopicPayloadPool
         return DYNAMIC_RESERVE_MEMORY_MODE;
     }
 
+private:
+
+    using TopicPayloadPool::get_payload;
+
 };
 
 }  // namespace rtps

src/cpp/rtps/history/TopicPayloadPool_impl/DynamicReusable.hpp

@@ -41,6 +41,10 @@ class DynamicReusableTopicPayloadPool : public TopicPayloadPool
         return DYNAMIC_REUSABLE_MEMORY_MODE;
     }
 
+private:
+
+    using TopicPayloadPool::get_payload;
+
 };
 
 }  // namespace rtps

src/cpp/rtps/history/TopicPayloadPool_impl/Preallocated.hpp

@@ -80,6 +80,8 @@ class PreallocatedTopicPayloadPool : public TopicPayloadPool
 
 private:
 
+    using TopicPayloadPool::get_payload;
+
     uint32_t payload_size_;
     uint32_t minimum_pool_size_;    //< Minimum initial pool size (sum of all histories)
 };

src/cpp/rtps/history/TopicPayloadPool_impl/PreallocatedWithRealloc.hpp

@@ -80,6 +80,8 @@ class PreallocatedReallocTopicPayloadPool : public TopicPayloadPool
 
 private:
 
+    using TopicPayloadPool::get_payload;
+
     uint32_t min_payload_size_;
     uint32_t minimum_pool_size_;    //< Minimum initial pool size (sum of all histories)
 };

src/cpp/rtps/transport/TCPTransportInterface.h

@@ -74,6 +74,8 @@ class TCPTransportInterface : public TransportInterface
 
     std::atomic<bool> alive_;
 
+    using TransportInterface::transform_remote_locator;
+
 protected:
 
     std::vector<fastrtps::rtps::IPFinder::info_IP> current_interfaces_;

src/cpp/rtps/transport/UDPTransportInterface.h

@@ -37,6 +37,8 @@ class UDPTransportInterface : public TransportInterface
 {
     friend class UDPSenderResource;
 
+    using TransportInterface::transform_remote_locator;
+
 public:
 
     ~UDPTransportInterface() override;

src/cpp/rtps/transport/shared_mem/SharedMemTransport.h

@@ -200,6 +200,8 @@ class SharedMemTransport : public TransportInterface
 
 private:
 
+    using TransportInterface::transform_remote_locator;
+
     //! Constructor with no descriptor is necessary for implementations derived from this class.
     SharedMemTransport();
 

src/cpp/statistics/rtps/monitor-service/MonitorServiceListener.hpp

@@ -70,7 +70,9 @@ class MonitorServiceListener :
 
     MonitorService* monitor_srv_;
 
+private:
 
+    using fastrtps::rtps::WriterListener::onWriterMatched;
 };
 
 #endif // FASTDDS_STATISTICS

test/blackbox/api/dds-pim/PubSubParticipant.hpp

@@ -192,6 +192,8 @@ class PubSubParticipant
 
     private:
 
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
+
         ParticipantListener& operator =(
                 const ParticipantListener&) = delete;
         PubSubParticipant* participant_;

test/blackbox/api/dds-pim/PubSubReader.hpp

@@ -142,6 +142,9 @@ class PubSubReader
 
     private:
 
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
+        using eprosima::fastdds::dds::DomainParticipantListener::on_publisher_discovery;
+
         ParticipantListener& operator =(
                 const ParticipantListener&) = delete;
         PubSubReader& reader_;

test/blackbox/api/dds-pim/PubSubWriter.hpp

@@ -156,6 +156,10 @@ class PubSubWriter
 
     private:
 
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
+        using eprosima::fastdds::dds::DomainParticipantListener::on_publisher_discovery;
+        using eprosima::fastdds::dds::DomainParticipantListener::on_subscriber_discovery;
+
         ParticipantListener& operator =(
                 const ParticipantListener&) = delete;
 

test/blackbox/api/dds-pim/PubSubWriterReader.hpp

@@ -168,6 +168,10 @@ class PubSubWriterReader
 
     private:
 
+        using eprosima::fastdds::dds::DomainParticipantListener::on_participant_discovery;
+        using eprosima::fastdds::dds::DomainParticipantListener::on_publisher_discovery;
+        using eprosima::fastdds::dds::DomainParticipantListener::on_subscriber_discovery;
+
         //! Mutex guarding all info collections
         mutable std::mutex info_mutex_;
         //! The discovered participants excluding the participant this listener is listening to

test/blackbox/common/DDSBlackboxTestsBasic.cpp

@@ -477,8 +477,10 @@ TEST(DDSBasic, PidRelatedSampleIdentity)
 TEST(DDSBasic, IgnoreParticipant)
 {
 
-    struct IgnoringDomainParticipantListener : public DomainParticipantListener
+    class IgnoringDomainParticipantListener : public DomainParticipantListener
     {
+    public:
+
         std::atomic_int num_matched{0};
         std::atomic_int num_ignored{0};
 
@@ -505,6 +507,9 @@ TEST(DDSBasic, IgnoreParticipant)
             }
         }
 
+    private:
+
+        using DomainParticipantListener::on_participant_discovery;
     };
     // Set DomainParticipantFactory to create disabled entities
     DomainParticipantFactoryQos factory_qos;