-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20120] TCPSendResources cleanup #4300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport 2.12.x 2.11.x 2.10.x 2.6.x |
✅ Backports have been created
|
@richiprosima please test this |
jepemi
force-pushed
the
bugfix/transport_sanitizer_event
branch
from
January 31, 2024 07:22
56b33ff
to
02fd064
Compare
13 tasks
jepemi
force-pushed
the
bugfix/transport_sanitizer_event
branch
from
February 9, 2024 11:43
07bfc00
to
b4a0291
Compare
jepemi
changed the base branch from
master
to
bugfix/client_server_tcp_decision_making
February 9, 2024 11:44
jepemi
force-pushed
the
bugfix/client_server_tcp_decision_making
branch
from
February 12, 2024 09:26
48490ee
to
787a1dd
Compare
cferreiragonz
force-pushed
the
bugfix/client_server_tcp_decision_making
branch
from
February 13, 2024 07:09
76ae392
to
e2d6fe3
Compare
Base automatically changed from
bugfix/client_server_tcp_decision_making
to
master
February 14, 2024 14:48
@Mergifyio rebase |
☑️ Nothing to do
|
@jepemi can you address the conflicts, please? 😀 |
jepemi
force-pushed
the
bugfix/transport_sanitizer_event
branch
2 times, most recently
from
February 21, 2024 12:00
b447b82
to
da1e7d6
Compare
jepemi
changed the title
[20120] Transports sanitizer timed event
[20120] TCPSendResources cleanup
Feb 21, 2024
Implementation would not be ready for the v2.13.3 release. I'm moving this to 2.13.4 |
jepemi
added a commit
that referenced
this pull request
Mar 11, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
jepemi
added a commit
that referenced
this pull request
Mar 11, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> Refs #20120: Solve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
jepemi
added a commit
that referenced
this pull request
Mar 13, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> Refs #20120: Solve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
jepemi
added a commit
that referenced
this pull request
Mar 13, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
jepemi
added a commit
that referenced
this pull request
Mar 13, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> Refs #20120: Solve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 15, 2024
* TCPSendResources cleanup (#4300) * Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> Refs #20120: Solve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Skip tcpv6 on macOS Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
MiguelCompany
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Protect asio exception hotfix (#4527) * Refs #20599: Handle error code before function call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 08193d5) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp * Backport of #4319 && Partial backport of #4300 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
cferreiragonz
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Mar 20, 2024
* TCPSendResources cleanup (#4300) * Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> * Refs #20120: Solve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>
elianalf
pushed a commit
that referenced
this pull request
Mar 20, 2024
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Protect asio exception hotfix (#4527) * Refs #20599: Handle error code before function call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 08193d5) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp * Backport of #4319 && Partial backport of #4300 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
1 task
EduPonz
added a commit
that referenced
this pull request
Mar 22, 2024
* Refs #20120: Remove unused include * Refs #20120: TCP event call * Refs #20120: Sanitize transport * Refs #20120: Added tests and minor fixes * Refs #20120: Extended doxygen description and added to versions.md * Refs #20120: Uncrustify * Refs #20120: Add missing header * Refs #20120: Fix tests * Refs #20120: Uncrustify * Refs #20120: After client-server decision making rebase, not working * Refs #20120: Update * Refs #20120: Fix for chaining-transports * Refs #20120: Add new channel connection status and tests * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding * Refs #20120: Uncrustify * Refs #20120: Add unittests * Refs #20120: Fix deadlock * Refs #20120: Fix unittest * Refs #20120: Fix asio throwing exceptions * Refs #20120: Unnittest untab * Refs #20120: Apply suggestions * Refs #20120: Uncrustify * Refs #20120: Consider wan case + associated tests * Refs #20120: Remove versions.md update * Refs #20120: Fix rebasing wrong deletion * Refs #20120: Delete assert clause * Refs #20120: Apply suggestions --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
Apr 4, 2024
* Protect asio exception hotfix (#4527) * Refs #20599: Handle error code before function call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 08193d5) * Backport of #4319 && Partial backport of #4300 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
jepemi
added a commit
that referenced
this pull request
Apr 23, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
Mario-DL
pushed a commit
that referenced
this pull request
May 20, 2024
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
May 27, 2024
* TCPSendResources cleanup (#4300) * Refs #20120: Remove unused include Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> * Refs #20120: Solve conflicts Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20989: Fix test sources, prevent asio compilation error in windows Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20989: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20989: Add boost asio to WriterProxyAcknackTests CMakeLists.txt Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
cferreiragonz
added a commit
that referenced
this pull request
May 27, 2024
* Protect asio exception hotfix (#4527) * Refs #20599: Handle error code before function call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 08193d5) * Backport of #4319 && Partial backport of #4300 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com>
EduPonz
pushed a commit
that referenced
this pull request
May 29, 2024
* Protect asio exception hotfix (#4527) * Refs #20599: Handle error code before function call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 08193d5) # Conflicts: # src/cpp/rtps/transport/TCPTransportInterface.cpp * Backport of #4319 && Partial backport of #4300 * Protect asio exception hotfix (#4527) * Refs #20599: Handle error code before function call Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Apply suggestion Co-authored-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 08193d5) * Backport of #4319 && Partial backport of #4300 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TCP send resources weren't being cleaned after the disconnection of the other peer. This lead to a constantly increasing list of send resources which had to be traversed on each send call.
This PR introduces a new callback that erases the send resource associated to a remote participant that has been removed, except if it belongs to the initial peers list. It also erases the channel from the channel resources map of the associated TCPTransport.
@Mergifyio backport 2.12.x 2.10.x 2.6.x
Fixes #4122
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist