[20165] Add tests for TypeLookup service

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp

@@ -218,6 +218,7 @@ void TypeLookupReplyListener::check_get_types_reply(
     }
     else
     {
+        typelookup_manager_->notify_callbacks(RETCODE_NO_DATA, type_id);
         EPROSIMA_LOG_WARNING(TYPELOOKUP_SERVICE_REPLY_LISTENER,
                 "Received reply with no types.");
         register_result = RETCODE_ERROR;

src/cpp/fastdds/xtypes/type_representation/TypeObjectRegistry.cpp

@@ -918,11 +918,47 @@ const TypeIdentifier TypeObjectRegistry::get_complementary_type_identifier(
 {
     if (TypeObjectUtils::is_direct_hash_type_identifier(type_id))
     {
-        std::lock_guard<std::mutex> data_guard(type_object_registry_mutex_);
+        std::unique_lock<std::mutex> lock(type_object_registry_mutex_);
         auto it = type_registry_entries_.find(type_id);
         if (type_registry_entries_.end() != it)
         {
-            return it->second.complementary_type_id;
+            if (TK_NONE != it->second.complementary_type_id._d())
+            {
+                return it->second.complementary_type_id;
+            }
+            else
+            {
+                TypeRegistryEntry minimal_entry;
+                CompleteTypeObject complete_type_object = it->second.type_object.complete();
+                lock.unlock();
+                minimal_entry.type_object = build_minimal_from_complete_type_object(complete_type_object);
+                minimal_entry.complementary_type_id = type_id;
+                TypeIdentifier minimal_type_id = calculate_type_identifier(
+                    minimal_entry.type_object,
+                    minimal_entry.type_object_serialized_size);
+
+                lock.lock();
+                auto min_entry_result {type_registry_entries_.insert(
+                                           {minimal_type_id, minimal_entry})};
+                if (!min_entry_result.second)
+                {
+                    EPROSIMA_LOG_INFO(
+                        XTYPES_TYPE_REPRESENTATION,
+                        "Minimal type identifier already registered his EK_MINIMAL remotely.");
+                }
+                it = type_registry_entries_.find(type_id);
+                assert(type_registry_entries_.end() != it);
+                it->second.complementary_type_id = minimal_type_id;
+
+                return minimal_type_id;
+            }
+        }
+        else
+        {
+            EPROSIMA_LOG_WARNING(
+                XTYPES_TYPE_REPRESENTATION,
+                "Complete type identifier was not registered previously.");
+
         }
     }
     return type_id;
@@ -1375,12 +1411,7 @@ const TypeIdentifier TypeObjectRegistry::minimal_from_complete_type_identifier(
     switch (type_id._d()){
         case EK_COMPLETE:
         {
-            std::lock_guard<std::mutex> data_guard(type_object_registry_mutex_);
-            auto it = type_registry_entries_.find(type_id);
-            if (type_registry_entries_.end() != it)
-            {
-                return it->second.complementary_type_id;
-            }
+            return get_complementary_type_identifier(type_id);
         }
         break;
         case TI_PLAIN_SEQUENCE_SMALL:

test/unittest/dds/xtypes/type_lookup_service/TypeLookupServiceTests.cpp

@@ -618,6 +618,7 @@ TEST_F(TypeLookupServiceTests, TypeLookupReplyListener_wrong_replyid)
     tlm_->async_get_type_requests_.emplace(valid_sampleidentity(), tidws);
 
     TypeLookup_Reply reply;
+    reply.header().relatedRequestId(valid_sampleidentity());
     reply.return_value()._default();
     ReplyWithServerGUID reply_with_guid;
     reply_with_guid.reply = reply;
@@ -632,7 +633,7 @@ TEST_F(TypeLookupServiceTests, TypeLookupReplyListener_wrong_replyid)
 TEST_F(TypeLookupServiceTests, TypeLookupReplyListener_getTypes_empty)
 {
     MockLogConsumer* log_consumer =
-            setup_expect_log_msg("TYPELOOKUP_SERVICE_REPLY_LISTENER", "Reply no contains any type.");
+            setup_expect_log_msg("TYPELOOKUP_SERVICE_REPLY_LISTENER", "Received reply with no types.");
 
     TypeIdentfierWithSize tidws;
     tlm_->async_get_type_requests_.emplace(valid_sampleidentity(), tidws);
@@ -852,7 +853,7 @@ TEST_F(TypeLookupServiceTests, TypeLookupRequestListener_getTypes_empty)
 {
     MockLogConsumer* log_consumer =
             setup_expect_log_msg("TYPELOOKUP_SERVICE_REQUEST_LISTENER",
-                    "Request no contains any type identifier.");
+                    "Received request with no type identifiers.");
 
     TypeIdentfierWithSize tidws;
     tlm_->async_get_type_requests_.emplace(valid_sampleidentity(), tidws);