-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20141] Fix TCP reconnection after open logical port failure (backport #4324) #4422
Conversation
@jepemi would you mind taking a look at the conflicts ? |
da8dc80
to
21be33e
Compare
9ece5b6
to
c98e924
Compare
@jepemi next one in the loop ! Would you mind addressing the conflicts here ? |
* Refs #20141: Relocate pending ports erasing Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Add test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Fix asan tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Changes after rebase Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20141: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 3db2db8)
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
21be33e
to
c077af7
Compare
@richiprosima please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed tests unrelated to this PR. LGTM
This is an automatic backport of pull request #4324 done by Mergify.
Cherry-pick of 3db2db8 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com