Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20511] Add missing virtual destructor for StatisticsAncillary #4457

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 27, 2024

Description

This PR is a partial backport of #4448 to add a missing virtual destructor.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.6.8 milestone Feb 27, 2024
@EduPonz
Copy link
Author

EduPonz commented Feb 27, 2024

@richiprosima please test this

@EduPonz EduPonz mentioned this pull request Feb 27, 2024
7 tasks
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 27, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failed tests on windows github were already addressed in #4275

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 6, 2024
@EduPonz EduPonz merged commit 1872f04 into 2.6.x Mar 6, 2024
10 of 17 checks passed
@EduPonz EduPonz deleted the fix/2.6.x/statistics_missing_virtual_dtor branch March 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants