Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20415] Update APIs in video performance tests #4464

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Feb 28, 2024

Description

This PR substitutes the old APIs with new ones in supports files for video performance tests.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added this to the v2.13.4 milestone Feb 28, 2024
@JesusPoderoso JesusPoderoso modified the milestones: v2.13.4, v2.14.0 Feb 29, 2024
JesusPoderoso

This comment was marked as resolved.

@JesusPoderoso

This comment was marked as resolved.

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Copy link
Contributor Author

elianalf commented Mar 5, 2024

@richiprosima please test this

Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz added ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 5, 2024
@EduPonz EduPonz merged commit 6eec2ea into master Mar 5, 2024
12 of 17 checks passed
@EduPonz EduPonz deleted the release-v3/update_test_api branch March 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants