[20589] Set real TCP non_blocking_send limitation #4502

jepemi · 2024-03-05T10:33:45Z

Description

Since TCP actually allocates twice the size of the requested buffer, TCP non_blocking_send should not skip a send until this limit is reached.
This PR doubles the limit from which a send should not be tried if TCP non_blocking_send is set to true.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

EduPonz · 2024-03-23T07:22:41Z

@richiprosima please test this

EduPonz · 2024-03-25T19:14:33Z

@richiprosima please test this

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

EduPonz · 2024-03-26T07:23:22Z

@richiprosima please test this

EduPonz · 2024-03-27T13:15:08Z

@Mergifyio backport 2.13.x 2.10.x 2.6.x

mergify · 2024-03-27T13:15:18Z

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

#4629 [20589] Set real TCP non_blocking_send limitation (backport #4502) has been created for branch 2.13.x but encountered conflicts
#4630 [20589] Set real TCP non_blocking_send limitation (backport #4502) has been created for branch 2.10.x but encountered conflicts
#4631 [20589] Set real TCP non_blocking_send limitation (backport #4502) has been created for branch 2.6.x but encountered conflicts

* Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 33eb8be) # Conflicts: # test/unittest/transport/TCPv4Tests.cpp

* Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 33eb8be)

* Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 33eb8be) Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>

* Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 33eb8be)

* Set real TCP non_blocking_send limitation (#4502) * Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> (cherry picked from commit 33eb8be) * Refs #20589: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* Refs #20589: Set real non_blocking_send limitation * Refs #20589: Readapt test * Refs #20589: Fix failing test in macos/linux * Refs #20589: Uncrustify * Refs #20589: Fix unused variable --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com>

JesusPoderoso added this to the v2.14.1 milestone Mar 5, 2024

EduPonz previously approved these changes Mar 23, 2024

View reviewed changes

EduPonz added the ci-pending PR which CI is running label Mar 23, 2024

jepemi dismissed EduPonz’s stale review via 4a9d4d3 March 25, 2024 14:48

jepemi force-pushed the bugfix/tcp_non_blocking_send_double_limit branch from 371a955 to 4a9d4d3 Compare March 25, 2024 14:48

EduPonz previously approved these changes Mar 25, 2024

View reviewed changes

EduPonz self-requested a review March 25, 2024 19:14

EduPonz added to-do and removed ci-pending PR which CI is running labels Mar 26, 2024

jepemi added 5 commits March 26, 2024 08:11

Refs #20589: Set real non_blocking_send limitation

b1a3c58

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20589: Readapt test

28139a7

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20589: Fix failing test in macos/linux

432d600

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20589: Uncrustify

6b967d8

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20589: Fix unused variable

854dd37

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

jepemi dismissed EduPonz’s stale review via 854dd37 March 26, 2024 07:18

jepemi force-pushed the bugfix/tcp_non_blocking_send_double_limit branch from 4a9d4d3 to 854dd37 Compare March 26, 2024 07:18

jepemi added ci-pending PR which CI is running and removed to-do labels Mar 26, 2024

EduPonz approved these changes Mar 26, 2024

View reviewed changes

EduPonz self-requested a review March 26, 2024 07:23

EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Mar 27, 2024

EduPonz approved these changes Mar 27, 2024

View reviewed changes

EduPonz merged commit 33eb8be into master Mar 27, 2024
12 of 16 checks passed

EduPonz deleted the bugfix/tcp_non_blocking_send_double_limit branch March 27, 2024 13:14

mergify bot mentioned this pull request Mar 27, 2024

[20589] Set real TCP non_blocking_send limitation (backport #4502) #4629

Merged

11 tasks

mergify bot mentioned this pull request Mar 27, 2024

[20589] Set real TCP non_blocking_send limitation (backport #4502) #4630

Merged

11 tasks

mergify bot mentioned this pull request Mar 27, 2024

[20589] Set real TCP non_blocking_send limitation (backport #4502) #4631

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20589] Set real TCP non_blocking_send limitation #4502

[20589] Set real TCP non_blocking_send limitation #4502

jepemi commented Mar 5, 2024 •

edited by EduPonz

Loading

EduPonz commented Mar 23, 2024

EduPonz commented Mar 25, 2024

EduPonz commented Mar 26, 2024

EduPonz commented Mar 27, 2024

mergify bot commented Mar 27, 2024 •

edited

Loading

[20589] Set real TCP non_blocking_send limitation #4502

[20589] Set real TCP non_blocking_send limitation #4502

Conversation

jepemi commented Mar 5, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

EduPonz commented Mar 23, 2024

EduPonz commented Mar 25, 2024

EduPonz commented Mar 26, 2024

EduPonz commented Mar 27, 2024

mergify bot commented Mar 27, 2024 • edited Loading

✅ Backports have been created

jepemi commented Mar 5, 2024 •

edited by EduPonz

Loading

mergify bot commented Mar 27, 2024 •

edited

Loading